Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Feature/byer3/mass inj constraint fix #3495

Merged
merged 17 commits into from
Jan 8, 2025

Conversation

tjb-ltk
Copy link
Contributor

@tjb-ltk tjb-ltk commented Dec 17, 2024

Add missing logic to support switching from fixed mass rate injection rate constraint to max injection pressure. The code will crash if running a model where this condition is encountered. No issues with mass injection constraint in scenarios where pressure associated with injection rate is less than maximum injection pressure. 2 test cases added to demonstrate constraint switching using mass injection rate constraint and total injection rate tables. The cases should produce nearly identical results.

@tjb-ltk tjb-ltk changed the title Feature/byer3/mass inj constraint fix fix: Feature/byer3/mass inj constraint fix Dec 18, 2024
@tjb-ltk tjb-ltk self-assigned this Dec 18, 2024
@tjb-ltk tjb-ltk added flag: requires rebaseline Requires rebaseline branch in integratedTests ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Dec 18, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.79%. Comparing base (a8a57c7) to head (0ef692e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rs/fluidFlow/wells/CompositionalMultiphaseWell.cpp 72.72% 3 Missing ⚠️
...lls/kernels/CompositionalMultiphaseWellKernels.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3495      +/-   ##
===========================================
+ Coverage    56.78%   56.79%   +0.01%     
===========================================
  Files         1154     1154              
  Lines       100057   100074      +17     
===========================================
+ Hits         56815    56836      +21     
+ Misses       43242    43238       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltomin paveltomin merged commit 907fb3f into develop Jan 8, 2025
26 checks passed
@paveltomin paveltomin deleted the feature/byer3/mass_inj_constraint_fix branch January 8, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants