-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Feature/byer3/mass inj constraint fix #3495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjb-ltk
requested review from
CusiniM,
paveltomin,
ryar9534 and
dkachuma
as code owners
December 17, 2024 18:59
paveltomin
reviewed
Dec 17, 2024
src/coreComponents/physicsSolvers/fluidFlow/wells/CompositionalMultiphaseWell.cpp
Outdated
Show resolved
Hide resolved
paveltomin
approved these changes
Dec 17, 2024
tjb-ltk
changed the title
Feature/byer3/mass inj constraint fix
fix: Feature/byer3/mass inj constraint fix
Dec 18, 2024
tjb-ltk
added
flag: requires rebaseline
Requires rebaseline branch in integratedTests
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
ci: run code coverage
enables running of the code coverage CI jobs
labels
Dec 18, 2024
CusiniM
approved these changes
Dec 31, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3495 +/- ##
===========================================
+ Coverage 56.78% 56.79% +0.01%
===========================================
Files 1154 1154
Lines 100057 100074 +17
===========================================
+ Hits 56815 56836 +21
+ Misses 43242 43238 -4 ☔ View full report in Codecov by Sentry. |
paveltomin
requested review from
rrsettgast,
cssherman,
wrtobin,
castelletto1 and
jhuang2601
as code owners
January 7, 2025 18:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run code coverage
enables running of the code coverage CI jobs
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: ready for review
flag: requires rebaseline
Requires rebaseline branch in integratedTests
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing logic to support switching from fixed mass rate injection rate constraint to max injection pressure. The code will crash if running a model where this condition is encountered. No issues with mass injection constraint in scenarios where pressure associated with injection rate is less than maximum injection pressure. 2 test cases added to demonstrate constraint switching using mass injection rate constraint and total injection rate tables. The cases should produce nearly identical results.