Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array layouts #296

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Array layouts #296

wants to merge 1 commit into from

Conversation

klevzoff
Copy link
Contributor

@klevzoff klevzoff commented Jul 11, 2023 •
edited
Loading

Proposal for new array layout types that allow for static (compile-time) extents and strides. Passes all unit tests.

Inspired by:
https://github.com/NVIDIA/cutlass/tree/main/include/cute
https://github.com/NVIDIA/cutlass/blob/main/media/docs/cute/00_quickstart.md

The main changes to look at (in order):

  • Constant.hpp/testConstant.hpp
  • tupleManipulation.hpp/testTupleManipulation.hpp
  • Layout.hpp/testLayout.hpp
  • then ArraySlice.hpp/ArrayView.hpp/Array.hpp

The type name changes (Array2 etc.) are temporary.

Build times for time ninja -j8 coreComponents/LvArray/all

  • develop:
real	4m51.127s
user	36m42.070s
sys	0m58.920s
  • feature/klevzoff/layouts:
real	4m57.517s
user	36m53.505s
sys	1m0.265s

@klevzoff klevzoff self-assigned this Jul 11, 2023
@klevzoff klevzoff force-pushed the feature/klevzoff/layouts branch from d3a7aeb to d9755cc Compare July 11, 2023 08:49
@klevzoff klevzoff force-pushed the feature/klevzoff/layouts branch 3 times, most recently from 6074837 to 5d63bf0 Compare August 29, 2023 09:47
@klevzoff klevzoff force-pushed the feature/klevzoff/layouts branch from 5d63bf0 to 9cbdb99 Compare September 3, 2023 09:54
@klevzoff klevzoff mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrtobin wrtobin Awaiting requested review from wrtobin

@rrsettgast rrsettgast Awaiting requested review from rrsettgast

@corbett5 corbett5 Awaiting requested review from corbett5

At least 1 approving review is required to merge this pull request.

Assignees

@klevzoff klevzoff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@klevzoff