Allow restart check to wait for files to write #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CusiniM
approved these changes
Mar 12, 2024
docs/index.rst
Outdated
| make ats_environment | ||
|
|
||
|
|
||
| These will attempt to install the required packages into the python distribution indicated via the `Python3_EXECUTABLE` cmake variable (also used by pygeosx). | ||
| If any package dependencies are missing, then the install script will attempt to fetch them from the internet using pip. | ||
| After installation, these packages will be available for import within the associated python distribution, and a set of console scripts will be available within the GEOSX build bin directory. |
There was a problem hiding this comment.
Suggested change
| After installation, these packages will be available for import within the associated python distribution, and a set of console scripts will be available within the GEOSX build bin directory. | |
| After installation, these packages will be available for import within the associated python distribution, and a set of console scripts will be available within the GEOS build bin directory. |
| self.compareGroups( file, base_file ) | ||
|
|
||
| else: | ||
| self.output.write( f"\nRank {rank} Failed to load target and/or baseline files \n" ) |
There was a problem hiding this comment.
maybe it is useful to know which of the two failed.
Suggested change
| self.output.write( f"\nRank {rank} Failed to load target and/or baseline files \n" ) | |
| if ( file is None ): | |
| self.output.write( f"\nRank {rank} Failed to load target files \n" ) | |
| if ( base_file is None ): | |
| self.output.write( f"\nRank {rank} Failed to load baseline files \n" ) |
There was a problem hiding this comment.
And I wonder if we should add the path info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.