Allowing previously passed ats tests to skip execution #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cssherman
commented
Mar 21, 2024
Comment on lines
+107
to
+108
| if self.test_results[ test_name ].previous_status == PASSED: | ||
| self.test_results[ test_name ].status = PASSED |
There was a problem hiding this comment.
Previously passed tests will report skipped instead of passed, so set the correct status here
There was a problem hiding this comment.
I see. Maybe we should set a dedicated status called PREVIOUSLY_PASSED ? Or are these values predefined by ats?
|
@CusiniM - this small change seems to fix the problem |
CusiniM
approved these changes
Apr 4, 2024
Comment on lines
+107
to
+108
| if self.test_results[ test_name ].previous_status == PASSED: | ||
| self.test_results[ test_name ].status = PASSED |
There was a problem hiding this comment.
I see. Maybe we should set a dedicated status called PREVIOUSLY_PASSED ? Or are these values predefined by ats?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.