Fix elements orderings to use cells volume #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce leading to error when creating documentation
…tation. Argparse filename used instead.
…dering now + better reordering stats output
alexbenedicto
changed the title
alexbenedicto
changed the title
…//github.com/GEOS-DEV/geosPythonPackages into origin/feature/fix_element_ordering_issue#35
alexbenedicto
deleted the
origin/feature/fix_element_ordering_issue#35
branch
alexbenedicto
restored the
origin/feature/fix_element_ordering_issue#35
branch
alexbenedicto
deleted the
origin/feature/fix_element_ordering_issue#35
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to issue #35
fix_elements_orderings feature would operate nodes ordering modification on all cells of a mesh that have a specific element type.
But if only half of the cells being of that specific cell type were invalid, all of them would still be reordered.
This PR aims at considering the volume of the cells to be taken into account when considering to reorder or not the nodes of a cell.