Revert "Build hdf5 using CMake instead of Autogen" #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CusiniM
approved these changes
Nov 1, 2023
TotoGaz
deleted the
revert-243-feature/algiane/NDEBUG-flag-in-Debug-build
branch
CusiniM
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Revert "Revert "Build hdf5 using CMake instead of Autogen" (#247)" This reverts commit dbf21a5. * Fix wrong use of CMAKE_SHARED_MODULE_SUFFIX instead of CMAKE_SHARED_LIBRARY_SUFFIX to find the extension of hdf5 shared library. * In Debug mode, build hdf5 in RelWithDebInfo mode to bypass the fact that Silo's autogen script searches for libhdf5 library while CMake's build of hdf5 creates the libhdf5_debug library in Debug mode. * If compiler is Clang, add the -w flag to Silo's compiler flags to avoid a compilation error with release 4.11 of Silo (fixed by release 4.11.1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #243
The paired PR GEOS-DEV/GEOS#2721 is still under review.