Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove RESQML support from tpls #258

Merged
merged 2 commits into from
Jun 12, 2024
Merged

remove RESQML support from tpls #258

merged 2 commits into from
Jun 12, 2024

Conversation

untereiner
Copy link

No description provided.

@untereiner untereiner requested a review from TotoGaz January 30, 2024 10:04
@untereiner untereiner self-assigned this Jan 30, 2024
@untereiner
Copy link
Author

untereiner commented Jan 30, 2024 •
edited
Loading

@TotoGaz The objective is too remove a non used and not maintained functionality. Does it worth also cleaning the GEOS repo ? For the record, everything is here and there, and up to date.

@TotoGaz
Copy link
Contributor

TotoGaz commented Jan 30, 2024 •
edited
Loading

At least I can spot some ENABLE_FESAPI that are worth removing in GEOS. Maybe other pieces of code here and there? You know better than me, I lean on you 😉

@untereiner untereiner mentioned this pull request Jan 31, 2024
Merged
@untereiner
Copy link
Author

@TotoGaz could you look at it ?

@untereiner untereiner force-pushed the feature/deleteFesapi branch from 5a590d3 to ded2047 Compare June 3, 2024 13:58
@CusiniM CusiniM merged commit 9690ba6 into master Jun 12, 2024
13 checks passed
@untereiner
Copy link
Author

Thank you @CusiniM

@untereiner untereiner deleted the feature/deleteFesapi branch June 13, 2024 07:30
@untereiner untereiner linked an issue Jun 21, 2024 that may be closed by this pull request
Fesapi won't build if environement variable CMAKE_BUILD_TYPE is set tu Debug #226
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TotoGaz TotoGaz TotoGaz approved these changes

Assignees

@untereiner untereiner

Labels
enhancement New feature or request flag: ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fesapi won't build if environement variable CMAKE_BUILD_TYPE is set tu Debug
3 participants
@untereiner @TotoGaz @CusiniM