Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/wjiang/set grid fix #2002

Closed
wants to merge 3 commits into from
Closed

Fix/wjiang/set grid fix #2002

wants to merge 3 commits into from

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Mar 6, 2023 •
edited
Loading

When set_grid is call, the cf_root is not created. So the GridType should come from cap.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Mar 6, 2023
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner March 6, 2023 14:46
@weiyuan-jiang
Copy link
Contributor Author

This fix is necessary for issue GEOS-ESM/GOCART#207

@mathomp4
Copy link
Member

mathomp4 commented Mar 6, 2023

I might need some @tclune thoughts on this. This might be better as a hotfix than a feature if you are saying the previous code wasn't right.

tclune
tclune requested changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - make this a hotfix.

@weiyuan-jiang
Copy link
Contributor Author

closed. Replaced by #2003

@mathomp4 mathomp4 deleted the fix/wjiang/set_grid_fix branch March 6, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune requested changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiyuan-jiang @mathomp4 @tclune