Remove organ function configuration #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinkp
force-pushed
the
feat/board-organ-functions-enum
branch
5 times, most recently
from
1eef4f4
to
70836b3
Compare
rinkp
changed the title
rinkp
force-pushed
the
feat/board-organ-functions-enum
branch
2 times, most recently
from
6f1dbf4
to
ef8939a
Compare
rinkp
force-pushed
the
feat/board-organ-functions-enum
branch
from
064905d
to
f8a8428
Compare
rinkp
force-pushed
the
feat/board-organ-functions-enum
branch
2 times, most recently
from
5e48c66
to
b600878
Compare
Todo: resolve non-negative-int in MeetingModel Alternative: abs on line 187
rinkp
force-pushed
the
feat/board-organ-functions-enum
branch
from
b600878
to
a5f0c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the function configuration. This allows for function translation and cross-system usage of the function value in a standardised format.
Related issues/external references
Fixes GH-398
Types of changes
Breaking change
I marked breaking change, but the values have been selected carefully to allow compatibility with the existing functions within GEWIS.
We require manual recreation of all subdecisions after this change, because we rename
contenttocontentNLand introduce acontentENcolumn.The statutory content is then still stored in the
contentcolumn, but we keep translating decisions a GEWISDB-only job (and not a gewisweb task)