Skip to content

wip: improved OrganInformation approval #490

wip: improved OrganInformation approval

wip: improved OrganInformation approval #490

Triggered via pull request December 11, 2024 07:27
Status Failure
Total duration 1m 15s
Artifacts

static-analysis-psalm.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

20 errors and 1 warning
InvalidReturnType: module/Decision/src/Controller/OrganAdminApprovalController.php#L48
module/Decision/src/Controller/OrganAdminApprovalController.php:48:39: InvalidReturnType: Not all code paths of Decision\Controller\OrganAdminApprovalController::approvalAction end in a return statement, return type Laminas\View\Model\ViewModel expected (see https://psalm.dev/011)
InvalidReturnType: module/Decision/src/Controller/OrganAdminApprovalController.php#L53
module/Decision/src/Controller/OrganAdminApprovalController.php:53:51: InvalidReturnType: Not all code paths of Decision\Controller\OrganAdminApprovalController::changeApprovalStatusAction end in a return statement, return type Laminas\Http\Response|Laminas\View\Model\ViewModel expected (see https://psalm.dev/011)
InvalidReturnType: module/Decision/src/Controller/OrganAdminApprovalController.php#L58
module/Decision/src/Controller/OrganAdminApprovalController.php:58:39: InvalidReturnType: Not all code paths of Decision\Controller\OrganAdminApprovalController::proposalAction end in a return statement, return type Laminas\View\Model\ViewModel expected (see https://psalm.dev/011)
InvalidReturnType: module/Decision/src/Controller/OrganAdminApprovalController.php#L63
module/Decision/src/Controller/OrganAdminApprovalController.php:63:51: InvalidReturnType: Not all code paths of Decision\Controller\OrganAdminApprovalController::changeProposalStatusAction end in a return statement, return type Laminas\Http\Response|Laminas\View\Model\ViewModel expected (see https://psalm.dev/011)
TypeDoesNotContainType: module/Decision/src/Controller/OrganAdminController.php#L105
module/Decision/src/Controller/OrganAdminController.php:105:13: TypeDoesNotContainType: Decision\Model\OrganInformation|null does not contain false (see https://psalm.dev/056)
InvalidArgument: module/Decision/src/Controller/OrganAdminController.php#L115
module/Decision/src/Controller/OrganAdminController.php:115:62: InvalidArgument: Argument 1 of Decision\Service\Organ::getOrganInformationForm expects Decision\Model\Organ|null, but Decision\Model\OrganInformation provided (see https://psalm.dev/004)
TypeDoesNotContainNull: module/Decision/src/Hydrator/OrganInformation.php#L49
module/Decision/src/Hydrator/OrganInformation.php:49:54: TypeDoesNotContainNull: Cannot resolve types for $<tmp coalesce var>1591 - Decision\Model\DecisionLocalisedText does not contain null (see https://psalm.dev/090)
TypeDoesNotContainNull: module/Decision/src/Hydrator/OrganInformation.php#L56
module/Decision/src/Hydrator/OrganInformation.php:56:53: TypeDoesNotContainNull: Cannot resolve types for $<tmp coalesce var>1852 - Decision\Model\DecisionLocalisedText does not contain null (see https://psalm.dev/090)
UnusedClosureParam: module/Decision/src/Module.php#L281
module/Decision/src/Module.php:281:94: UnusedClosureParam: Param container is never referenced in this method (see https://psalm.dev/188)
UnusedBaselineEntry: module/Activity/src/Controller/AdminController.php#L1
module/Activity/src/Controller/AdminController.php:0:0: UnusedBaselineEntry: Baseline for issue "PossiblyFalseReference" has 1 extra entry. (see https://psalm.dev/316)
PossiblyFalseReference: module/Activity/src/Controller/ActivityController.php#L88
module/Activity/src/Controller/ActivityController.php:88:75: PossiblyFalseReference: Cannot call method getId on possibly false value (see https://psalm.dev/105)
PossiblyFalseReference: module/Activity/src/Controller/AdminController.php#L151
module/Activity/src/Controller/AdminController.php:151:51: PossiblyFalseReference: Cannot call method getNew on possibly false value (see https://psalm.dev/105)
InvalidArgument: module/Activity/src/Controller/ApiController.php#L41
module/Activity/src/Controller/ApiController.php:41:30: InvalidArgument: Argument 1 of Laminas\View\Model\JsonModel::__construct expects ArrayAccess<string, mixed>|iterable<string, mixed>|null, but list{0?: array{beginTime: DateTime, categories: array<array-key, array{id: int, name: null|string, nameEn: null|string}>, company: Company\Model\Company|null, costs: null|string, costsEn: null|string, description: null|string, descriptionEn: null|string, endTime: DateTime, id: int, isMyFuture: bool, location: null|string, locationEn: null|string, name: null|string, nameEn: null|string, organ: Decision\Model\Organ|null, requireGEFLITST: bool, signupLists: array<array-key, array{closeDate: DateTime, displaySubscribedNumber: bool, fields: array<array-key, array{id: int, maximumValue: int|null, minimumValue: int|null, name: null|string, nameEn: null|string, options: array<array-key, null|string>, optionsEn: array<array-key, null|string>, sensitive: bool, type: int}>, id: int, limitedCapacity: bool, name: null|string, nameEn: null|string, onlyGEWIS: bool, openDate: DateTime}>}, ...<array{beginTime: DateTime, categories: array<array-key, array{id: int, name: null|string, nameEn: null|string}>, company: Company\Model\Company|null, costs: null|string, costsEn: null|string, description: null|string, descriptionEn: null|string, endTime: DateTime, id: int, isMyFuture: bool, location: null|string, locationEn: null|string, name: null|string, nameEn: null|string, organ: Decision\Model\Organ|null, requireGEFLITST: bool, signupLists: array<array-key, array{closeDate: DateTime, displaySubscribedNumber: bool, fields: array<array-key, array{id: int, maximumValue: int|null, minimumValue: int|null, name: null|string, nameEn: null|string, options: array<array-key, null|string>, optionsEn: array<array-key, null|string>, sensitive: bool, type: int}>, id: int, limitedCapacity: bool, name: null|string, nameEn: null|string, onlyGEWIS: bool, openDate: DateTime}>}>} provided (see https://psalm.dev/004)
MissingTemplateParam: module/Activity/src/Form/ActivityCalendarPeriod.php#L18
module/Activity/src/Form/ActivityCalendarPeriod.php:18:7: MissingTemplateParam: Activity\Form\ActivityCalendarPeriod has missing template params when extending Laminas\Form\Form, expecting 1 (see https://psalm.dev/182)
MissingTemplateParam: module/Activity/src/Form/ActivityCalendarProposal.php#L21
module/Activity/src/Form/ActivityCalendarProposal.php:21:7: MissingTemplateParam: Activity\Form\ActivityCalendarProposal has missing template params when extending Laminas\Form\Form, expecting 1 (see https://psalm.dev/182)
MissingTemplateParam: module/Activity/src/Form/Signup.php#L26
module/Activity/src/Form/Signup.php:26:7: MissingTemplateParam: Activity\Form\Signup has missing template params when extending Laminas\Form\Form, expecting 1 (see https://psalm.dev/182)
MoreSpecificReturnType: module/Activity/src/Mapper/Signup.php#L58
module/Activity/src/Mapper/Signup.php:58:78: MoreSpecificReturnType: The declared return type 'int' for Activity\Mapper\Signup::getNumberOfSignedUpMembers is more specific than the inferred return type 'null|scalar' (see https://psalm.dev/070)
PossiblyFalseReference: module/Activity/src/Service/Activity.php#L452
module/Activity/src/Service/Activity.php:452:37: PossiblyFalseReference: Cannot call method getNew on possibly false value (see https://psalm.dev/105)
MissingTemplateParam: module/Application/src/Form/Localisable.php#L15
module/Application/src/Form/Localisable.php:15:16: MissingTemplateParam: Application\Form\Localisable has missing template params when extending Laminas\Form\Form, expecting 1 (see https://psalm.dev/182)
MissingTemplateParam: module/Application/src/Form/ModifyRequest.php#L16
module/Application/src/Form/ModifyRequest.php:16:7: MissingTemplateParam: Application\Form\ModifyRequest has missing template params when extending Laminas\Form\Form, expecting 1 (see https://psalm.dev/182)
Psalm
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636