feat: activation is the new registration #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a notice to the login page during August and September to make it clear that activation (and setting a password) is required to be able to use the website. Furthermore, migrates fully to the `activate` endpoint to not cause any confusion. NOTE: this requires complementary changes in GEWISDB.
Because some people may not yet have activated their account on the website we should temporarily keep the original URL active.
Because people cannot understand "tomorrow". This does make me think, because in all other places we do not sync if `sync_paused` is reported via the API. Maybe we should make an API call before we sync?
5 tasks
tomudding
changed the title
github-actions bot
added a commit
that referenced
this pull request
Aug 24, 2024
Tom Udding: Merge pull request #1892 from tomudding/feature/account-activation-instead-of-registration feat: activation is the new registration Co-authored-by: tomudding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Activation is the new registration. Furthermore, sync frequency increased as I will be doing less and less for GEWISWEB.
Related issues/external references
Fixes GH-1891. See also GEWIS/gewisdb#431.
Types of changes