feat: improved activity overview #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't see why the unit test fails (it is the |
|
Made it a view helper because it keeps complaining and I cannot be bothered fixing the automated controller tests to determine why this is an issue. |
tomudding
force-pushed
the
feature/activity-overview-redesign
branch
from
774a3da to
39c8ce6
Compare
Gives the description of an activity more space (but also clamping it to at most 5 lines) by removing all event details on the right. Event details are now directly under the activity title (for date and time) or at the bottom (for costs and location). The date and time format has been condensed and a helper "for another X" / "in X" has been added to see how long an activity will still run or when it will start. Also allows links to be clicked in the description.
tomudding
force-pushed
the
feature/activity-overview-redesign
branch
from
39c8ce6 to
cb7c40b
Compare
github-actions bot
added a commit
that referenced
this pull request
Dec 8, 2024
Tom Udding: Merge pull request #1936 from tomudding/feature/activity-overview-redesign feat: improved activity overview Co-authored-by: tomudding <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gives the description of an activity more space (but also clamping it to at most 5 lines) by removing all event details on the right.
Event details are now directly under the activity title (for date and time) or at the bottom (for costs and location). The date and time format has been condensed and a helper "for another X" / "in X" has been added to see how long an activity will still run or when it will start.
Also allows links to be clicked in the description.
Before:
After:
Related issues/external references
Closes GH-1878.
Types of changes