fix: sizing of company logos in cards #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor of the card component removed the height restriction because the logos are not the same size (nor share an aspect ratio like cards for BM/GMM bodies). While I think that companies should provide proper logos (not ones with hundreds of white pixels as margin on each side), the board has asked to revert to same sizing to prevent certain companies from standing out in the overview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor of the card component removed the height restriction because the logos are not the same size (nor share an aspect ratio like cards for BM/GMM bodies).
While I think that companies should provide proper logos (not ones with hundreds of white pixels as margin on each side), the board has asked to revert to same sizing to prevent certain companies from standing out in the overview.
Before:
After:
Related issues/external references
As "discussed" during the ABC meeting yesterday.
Types of changes