feat(activity): add Zettle as option for facilities #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GEFLITST and Zettle are now "facilities" instead of "options" for an activity. --- I had a lengthy discussion with the BAC on whether they would want to be included in a similar way. In the end, we decided together that this was not desirable for the BAC. This is because people mostly already (have to) contact the BAC and this would then become more of a reminder (which is not necessary). From AViCo I have unfortunately never had a response in the past 2 months, should they still want to do so they are free to provide their own PR.
github-actions bot
added a commit
that referenced
this pull request
Feb 27, 2025
Tom Udding: Merge pull request #1990 from tomudding/feature/activity-facilities-update feat(activity): add Zettle as option for facilities Co-authored-by: tomudding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GEFLITST and Zettle are now "facilities" instead of "options" for an activity.
I had a lengthy discussion with the BAC on whether they would want to be included in a similar way. In the end, we decided together that this was not desirable for the BAC. This is because people mostly already (have to) contact the BAC and this would then become more of a reminder (which is not necessary).
From AViCo I have unfortunately never had a response in the past 2 months, should they still want to do so they are free to provide their own PR.
Related issues/external references
Closes GH-1904.
Types of changes