Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] Remove technical debt #189

Closed
3 of 5 tasks
SuperVK opened this issue May 28, 2024 · 5 comments
Closed
3 of 5 tasks

[Project] Remove technical debt #189

SuperVK opened this issue May 28, 2024 · 5 comments

Comments

@SuperVK
Copy link
Member

SuperVK commented May 28, 2024

Problem: The code style is all over the place, not consistency between them despite prettier and eslint existing.

Plan:

@SuperVK
Copy link
Member Author

SuperVK commented May 28, 2024

image
image
This is the current state of the repository

@CodeNamedRobin
Copy link
Contributor

ESLint is currently in one of the checks when opening a PR right? I think that can be closed as completed. We could run prettier when opening a PR as well.

@SuperVK
Copy link
Member Author

SuperVK commented Jun 15, 2024

Nope, that is also why eslint gives so many errors. Enabling it in the PR check will make it impossible to make PRs rn, so we need a strategy for it

@SuperVK SuperVK changed the title Improve code style [Project] Improve code style Jun 18, 2024
@SuperVK SuperVK mentioned this issue Jun 18, 2024
9 tasks
@JustSamuel
Copy link
Contributor

ESlint works on my machine

@SuperVK SuperVK changed the title [Project] Improve code style [Project] Remove technical debt Jul 24, 2024
@SuperVK
Copy link
Member Author

SuperVK commented Aug 28, 2024

Don't like this issue anymore, doesn't provide much value

@SuperVK SuperVK closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants