Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Prettier fix and enforce eslint/prettier #218

Open
SuperVK opened this issue Jun 18, 2024 · 1 comment
Open

[Refactor] Prettier fix and enforce eslint/prettier #218

SuperVK opened this issue Jun 18, 2024 · 1 comment

Comments

@SuperVK
Copy link
Member

SuperVK commented Jun 18, 2024

We should run a prettier such that code style is consistent, furthermore ideally prettier and eslint are first tried seperately in the ci/cd, and if they fail do not attempt other CI/CD checks, to prevent unnecessary usage.

@SuperVK SuperVK changed the title [Refactor] ESLint fix and enforce [Refactor] ESLint/prettier fix and enforce Jun 18, 2024
@SuperVK SuperVK changed the title [Refactor] ESLint/prettier fix and enforce [Refactor] Prettier fix and enforce Jul 26, 2024
@SuperVK SuperVK changed the title [Refactor] Prettier fix and enforce [Refactor] Prettier fix and enforce eslint/prettier Jul 26, 2024
@SuperVK
Copy link
Member Author

SuperVK commented Sep 18, 2024

Talked about this a bit with Samuel, best approach would be to use eslint in a central config, then use either prettier or eslint.style for prettying. Then we can use husky to execute prettier on each commit, and eslint as a first enforce to catch common code smells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant