-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/admin single user view #314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeNamedRobin
force-pushed
the
refactor/admin-single-user-view
branch
2 times, most recently
from
August 26, 2024 20:48
a38f2a8
to
8ff8856
Compare
Please add screenshots highlight your changes :( |
CodeNamedRobin
force-pushed
the
refactor/admin-single-user-view
branch
from
August 28, 2024 13:12
f08fcfc
to
0a016b2
Compare
CodeNamedRobin
force-pushed
the
refactor/admin-single-user-view
branch
from
August 28, 2024 19:34
0a016b2
to
90f5ab2
Compare
SuperVK
reviewed
Aug 29, 2024
apps/dashboard/src/modules/seller/components/ProductActionExistingProductForm.vue
Outdated
Show resolved
Hide resolved
SuperVK
reviewed
Aug 29, 2024
apps/dashboard/src/modules/seller/components/ProductActionImageForm.vue
Outdated
Show resolved
Hide resolved
Nickname cannot be null is still an issue, to replicate:
|
JustSamuel
requested changes
Aug 29, 2024
apps/dashboard/src/modules/admin/components/users/AdminUserInfoCard.vue
Outdated
Show resolved
Hide resolved
apps/dashboard/src/modules/admin/components/users/forms/UserEditForm.vue
Outdated
Show resolved
Hide resolved
This has been fixed in the latest commit. |
CodeNamedRobin
force-pushed
the
refactor/admin-single-user-view
branch
from
August 30, 2024 12:26
ff447fa
to
955eb28
Compare
JustSamuel
approved these changes
Aug 30, 2024
… and dependencies
…putspan breaks the page
… User info card and the balance card
…ough it is allowed
CodeNamedRobin
force-pushed
the
refactor/admin-single-user-view
branch
from
August 30, 2024 13:34
955eb28
to
3d07f64
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the single user view for admins. Refactors the user edit form to use the new form implementation, and clears up a lot of functional code in the main component, moving it to separate components. Below is what the page looks like now.
Related issues/external references
One of many #273
One of many #228 (admin single user view having functional code)
One of many #228 (removing changeinfocomponent)
Types of changes