Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/admin single user view #314

Merged
merged 14 commits into from
Aug 30, 2024

Conversation

CodeNamedRobin
Copy link
Contributor

@CodeNamedRobin CodeNamedRobin commented Aug 26, 2024

Description

Refactors the single user view for admins. Refactors the user edit form to use the new form implementation, and clears up a lot of functional code in the main component, moving it to separate components. Below is what the page looks like now.
image

Related issues/external references

One of many #273
One of many #228 (admin single user view having functional code)
One of many #228 (removing changeinfocomponent)

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Style (Change that do not affect the functionality of the code)

@CodeNamedRobin CodeNamedRobin force-pushed the refactor/admin-single-user-view branch 2 times, most recently from a38f2a8 to 8ff8856 Compare August 26, 2024 20:48
@CodeNamedRobin CodeNamedRobin marked this pull request as ready for review August 27, 2024 13:05
@JustSamuel
Copy link
Contributor

Please add screenshots highlight your changes :(

@SuperVK
Copy link
Member

SuperVK commented Aug 28, 2024

image
Nickname should be able to be null right?

Some translations missing as well. (Header, confirm message)

(bit irrelevant for here cause the backend allows it) Are we allowed to change the names of members account from GEWIS?

@SuperVK
Copy link
Member

SuperVK commented Aug 29, 2024

Nickname cannot be null is still an issue, to replicate:

  1. click on edit
  2. click on username
  3. de-focus the username field
  4. voila

@CodeNamedRobin
Copy link
Contributor Author

Nickname cannot be null is still an issue, to replicate:

1. click on edit

2. click on username

3. de-focus the username field

4. voila

This has been fixed in the latest commit.

@CodeNamedRobin CodeNamedRobin force-pushed the refactor/admin-single-user-view branch from ff447fa to 955eb28 Compare August 30, 2024 12:26
@CodeNamedRobin CodeNamedRobin force-pushed the refactor/admin-single-user-view branch from 955eb28 to 3d07f64 Compare August 30, 2024 13:34
@CodeNamedRobin CodeNamedRobin merged commit cc2d7b5 into develop Aug 30, 2024
3 checks passed
@CodeNamedRobin CodeNamedRobin deleted the refactor/admin-single-user-view branch August 30, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants