refactor(dashboard/user): profile view #320
Conversation
CodeNamedRobin
force-pushed
the
refactor/profile-view
branch
from
68a029e to
4e6c8f3
Compare
CodeNamedRobin
force-pushed
the
refactor/profile-view
branch
from
6e723ad to
dda7956
Compare
There was a problem hiding this comment.
It would be nice if the buttons for pop up change to a cursor mouse on hover, and I think you might as well change the password changing to be the same as the pin change? Not sure tbh, but this feels weird while they kinda do the same
And do we want to implement Roy's suggestion while we are at it: #268
|
Also I can't comment on the code, but the profile view somehow fetches all users and uses that to get your GEWIS id. But this endpoint will soon become privileged so it might be nice to do this differently (besides it already being very cursed that we fetch all users to just use one) |
A new get individual gewis user fetch function has been implemented in the user store now. |
feat(dashboard/user): added change pin dialog to user settings card
feat(dashboard/user-profile): removed dialog for changing pin, added form section for changing pin
… links and confirmation dialogs
…o user settings component
…ar sign fix(dashboard/user-profile-view): cursor not showing pointer on change api key and change password buttons
CodeNamedRobin
force-pushed
the
refactor/profile-view
branch
from
49b24b1 to
f7e78e3
Compare
Description
Refactors the entire profile view. Makes the profile view a lot neater, where no more cards are used for simple settings, instead all settings are in one user settings card.
Related issues/external references
Many of #273
Types of changes