Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks whether user-defined env.step method returns the expected type #165

Merged
merged 1 commit into from
Feb 25, 2024
Merged

checks whether user-defined env.step method returns the expected type #165

merged 1 commit into from
Feb 25, 2024

Conversation

josephdviviano
Copy link
Collaborator

This implements a check to ensure that any user-defined env.step() call returns a torch.Tensor instance, not a States instance.

@josephdviviano josephdviviano added the small Small enhancement label Feb 24, 2024
@josephdviviano josephdviviano self-assigned this Feb 24, 2024
@josephdviviano josephdviviano changed the title checks whether user-defined function returns the expected type checks whether user-defined env.step method returns the expected type Feb 24, 2024
@josephdviviano josephdviviano mentioned this pull request Feb 24, 2024
Closed
@saleml saleml merged commit 7996b37 into dont_recompute_masks Feb 25, 2024
3 checks passed
@josephdviviano josephdviviano deleted the step_type_checking branch February 25, 2024 23:02
@josephdviviano josephdviviano restored the step_type_checking branch November 15, 2024 00:49
@josephdviviano josephdviviano deleted the step_type_checking branch November 15, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleml saleml saleml approved these changes

Assignees

@josephdviviano josephdviviano

Labels
small Small enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephdviviano @saleml