-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conditional gfn #188
Merged
Merged
conditional gfn #188
Changes from 26 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
6e8dc4d
example of conditional GFN computation with TB only (for now)
josephdviviano 39fb5ee
should be no change
josephdviviano 2bc2263
Trajectories objects now have an optional .conditonal field which opt…
josephdviviano 99afaf3
small changes to logz paramater handling, optionally incorporate cond…
josephdviviano e6d25a0
logZ is optionally computed using a conditioning vector
josephdviviano 2c72bf9
NeuralNets now have input/output dims
josephdviviano 580c455
added a ConditionalDiscretePolicyEstimator, and the forward of GFNMod…
josephdviviano a74872f
added conditioning to sampler, which will save the tensor as an attri…
josephdviviano 056d935
black
josephdviviano 96b725c
API changes adapted
josephdviviano 5cd32a7
added conditioning to all gflownets
josephdviviano 877c4a0
both trajectories and transitions can now store a conditioning tensor
josephdviviano 279a313
input_dim setting is now private
josephdviviano 65135c1
added exception handling for all estimator calls potentially involvin…
josephdviviano b4c418c
API change -- n vs. n_trajectories
josephdviviano 738b062
change test_box target value
josephdviviano 4434e5f
API changes
josephdviviano 851e03e
hacky fix for problematic test (added TODO)
josephdviviano 5152295
working examples for all 4 major losses
josephdviviano 1d64b55
added conditioning indexing for correct broadcasting
josephdviviano 348ee82
added a ConditionalScalarEstimator which subclasses ConditionalDiscre…
josephdviviano 9120afe
added modified DB example
josephdviviano f59f4de
conditioning added to modified db example
josephdviviano c5ef7ea
black
josephdviviano d67dfd5
reorganized keyword arguments and fixed some type errors (not all)
josephdviviano d56a798
reorganized keyword arguments and fixed some type errors (not all)
josephdviviano db8844c
added typing and a ConditionalScalarEstimator
josephdviviano e03c03a
added typing
josephdviviano 6b47e06
typing
josephdviviano 988faf0
typing
josephdviviano f2bbce3
added kwargs
josephdviviano eb13a2d
renamed torso to trunk
josephdviviano fd3d9dc
renamed torso to trunk
josephdviviano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like you're handling the conditioning input to this function as a kwarg, whereas
sampler
'ssample_trajectories
have an explicitconditioning
input. I'm wondering if you have a particular reason for this choiceThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe all functions should use an explicit
conditioning
kwarg, what do you think? I can make those changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it would be cleaner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be done now, let me know if i missed something.