Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactorings and Rename NeuralNet to MLP #203

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

hyeok9855
Copy link
Collaborator

This commit contains:

  • several incremental refactorings
  • remaning NeuralNet to MLP, considering the broader concept of neural network.

@hyeok9855 hyeok9855 self-assigned this Oct 18, 2024
@hyeok9855 hyeok9855 added the small Small enhancement label Oct 18, 2024
@josephdviviano
Copy link
Collaborator

I think you just need to resolve conflict with recent updates to master

Copy link
Collaborator

@josephdviviano josephdviviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! A few style / other questions (nothing major but good to get on the same page before approval).

src/gfn/containers/replay_buffer.py Show resolved Hide resolved
src/gfn/env.py Show resolved Hide resolved
src/gfn/gym/helpers/preprocessors.py Outdated Show resolved Hide resolved
src/gfn/utils/__init__.py Outdated Show resolved Hide resolved
tutorials/examples/train_hypergrid.py Show resolved Hide resolved
tutorials/examples/train_hypergrid_simple.py Show resolved Hide resolved
Copy link
Collaborator

@josephdviviano josephdviviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! thanks

@hyeok9855 hyeok9855 merged commit 57cc269 into master Oct 29, 2024
3 checks passed
@younik younik mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Small enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants