small fixes to seeding and hypergrid tests, docstring improvements to resolve confusion of get_terminating_states_indices purpose
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephdviviano
changed the title
get_terminating_states_indices purpose
hyeok9855
approved these changes
Nov 15, 2024
| @@ -86,6 +86,7 @@ def update_masks(self, states: type[DiscreteStates]) -> None: | |||
| """Update the masks based on the current states.""" | |||
| # Not allowed to take any action beyond the environment height, but | |||
| # allow early termination. | |||
| # TODO: do we need to handle the conditional case here? | |||
There was a problem hiding this comment.
I don't think so. We may need another EnvBase that incorporates conditions.
There was a problem hiding this comment.
ConditionalEnvs are interesting. I should actually do this ASAP so we have a working conditional GFN example.
younik
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see title
was inspired by this issue #205