Make sure that all bytes are sent to the ANCP neighbor #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socket.send isn't guaranteed to send all bytes, even if the socket is blocking. It might happen, that the kernel doesn't accept all bytes, and some bytes are left in the Python send buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method socket.send() isn't guaranteed to send all bytes, even if the socket is blocking. It might happen, that the kernel doesn't accept all bytes, and some bytes are left in the Python send buffer.
Without the fix we're seeing missing bytes at the receiver, e.g. when sending 3000 subscribers in one
client.port_up(), only ~800 subscribers are received, while the last subscriber bytes are cut off. When using socket.sendall() everything works flawlessly