Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add click and drag to gene glyphs #269

Merged
merged 10 commits into from
Oct 24, 2023

Conversation

shashankbrgowda
Copy link
Contributor

@shashankbrgowda shashankbrgowda commented Sep 4, 2023

Fixes #263
Fixes #297

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #269 (0f58fb9) into main (47dca9f) will decrease coverage by 0.86%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 0f58fb9 differs from pull request most recent head e1132a9. Consider uploading reports for the commit e1132a9 to get more accurate results

@@           Coverage Diff            @@
##            main    #269      +/-   ##
========================================
- Coverage   8.53%   7.68%   -0.86%     
========================================
  Files         85      85              
  Lines       5012    5571     +559     
  Branches    1170    1410     +240     
========================================
  Hits         428     428              
- Misses      4212    4691     +479     
- Partials     372     452      +80     
Files Changed Coverage Δ
...-apollo/src/LinearApolloDisplay/glyphs/BoxGlyph.ts 0.00% <0.00%> (ø)
...c/LinearApolloDisplay/glyphs/CanonicalGeneGlyph.ts 0.00% <0.00%> (ø)
...rc/LinearApolloDisplay/glyphs/GenericChildGlyph.ts 0.00% <0.00%> (ø)
...gin-apollo/src/LinearApolloDisplay/glyphs/Glyph.ts 0.00% <0.00%> (ø)
...inearApolloDisplay/glyphs/ImplicitExonGeneGlyph.ts 0.00% <0.00%> (ø)
.../src/LinearApolloDisplay/stateModel/mouseEvents.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shashankbrgowda shashankbrgowda marked this pull request as ready for review September 12, 2023 08:56
@garrettjstevens
Copy link
Contributor

I added a few more things to this branch that had to do with changing feature locations. If a feature has multiple locations, they show up in the grid now:

localhost_3000__config=http%3A%2F%2Flocalhost%3A9000%2Fjbrowse_config json session=local-dTjulmG7w94BKprhKgK2j

@garrettjstevens garrettjstevens merged commit 5c57631 into GMOD:main Oct 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discontinuous locations are not shown in table editor Add click and drag to gene glyphs
2 participants