-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the getAccess
method in the CLI
#444
Conversation
16b74d0
to
28c2d33
Compare
@dariober When I was removing some of the Also, should this be removed? From what I remembered, Apollo3/packages/apollo-cli/src/utils.ts Line 25 in 28c2d33
|
Add test and fix test suite
@garrettjstevens Looks good to me
I changed edit.ts accordingly
Yes, it seems so. I removed it and simplified the checking if user is already logged in (674e4ff). |
Since we can parse the flags in the base class, this does so to reduce the verbosity of
getAccess()
.It also makes some fixes to get rid of some
eslint-disable
directives