Fix bug with incorrect coverage being rendered in jbrowse #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was browsing jbrowse as one does and found a location in a BAM file where the coverage was displayed wrong, approximately doubled, and at "static block" (the jbrowse-2-ism, not bam file format-ism) boundaries
i found that older versions did not have the bug, and bisected to a diff here in jbrowse 2 https://github.com/gmod/jbrowse-components/compare/82618939977da5e71a419~1..82618939977da5e71a419 which led to it being between v1.1.8..v2.0.0 in bam-js https://github.com/gmod/bam-js/compare/v1.1.18..v2.0.0
the cause is fairly technical but a refactoring oversight, where a new "chunk object" (bam file format-ism, representing a range in the file) was not constructed,
the diff was just this to fix
my guess is that this bug was somewhat rare but did happen
screenshots
after
before