Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-2515 - Adjust build commands #43

Merged
merged 1 commit into from May 23, 2018
Merged

GPII-2515 - Adjust build commands #43

merged 1 commit into from May 23, 2018

Conversation

gtirloni
Copy link
Contributor

Adjust build commands after GPII/linux#94

Test results:

$ DISPLAY=:0 vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Importing base box 'inclusivedesign/fedora27'...
==> default: Matching MAC address for NAT networking...
==> default: Checking if box 'inclusivedesign/fedora27' is up to date...
==> default: Setting the name of the VM: linux_default_1527074252100_88186
==> default: Clearing any previously set network interfaces...
==> default: Preparing network interfaces based on configuration...
    default: Adapter 1: nat
==> default: Forwarding ports...
    default: 8081 (guest) => 8081 (host) (adapter 1)
    default: 22 (guest) => 2222 (host) (adapter 1)
==> default: Running 'pre-boot' VM customizations...
==> default: Booting VM...
==> default: Waiting for machine to boot. This may take a few minutes...
    default: SSH address: 127.0.0.1:2222
    default: SSH username: vagrant
    default: SSH auth method: private key
    default: 
    default: Vagrant insecure key detected. Vagrant will automatically replace
    default: this with a newly generated keypair for better security.
    default: 
    default: Inserting generated public key within guest...
    default: Removing insecure key from the guest if it's present...
    default: Key inserted! Disconnecting and reconnecting using new SSH key...
==> default: Machine booted and ready!
==> default: Checking for guest additions in VM...
==> default: Setting hostname...
==> default: Mounting shared folders...
    default: /home/vagrant/sync => /home/gtirloni/linux
==> default: Running provisioner: shell...
    default: Running: inline script
==> default: Running provisioner: shell...
    default: Running: inline script
    default: - extracting facts to /root/.ansible/roles/facts
    default: - facts was installed successfully
    default: - extracting nodejs to /root/.ansible/roles/nodejs
    default: - nodejs was installed successfully
    default: - extracting gpii-framework to /root/.ansible/roles/gpii-framework
    default: - gpii-framework was installed successfully
    default: 
    default: PLAY [localhost] ***************************************************************
    default: 
    default: TASK [Gathering Facts] *********************************************************
    default: ok: [localhost]
    default: 
    default: TASK [facts : Set Fedora related facts] ****************************************
    default: ok: [localhost]
    default: 
    default: TASK [facts : Set CentOS related facts] ****************************************
    default: skipping: [localhost]
    default: 
    default: TASK [facts : Determine if Atomic] *********************************************
    default: ok: [localhost]
    default: 
    default: TASK [facts : Set Atomic related facts] ****************************************
    default: skipping: [localhost]
    default: 
    default: TASK [facts : Determine if has RPM] ********************************************
    default: ok: [localhost]
    default: 
    default: TASK [facts : Set RPM related facts] *******************************************
    default: ok: [localhost]
    default: 
    default: TASK [facts : Check for Docker related file] ***********************************
    default: ok: [localhost]
    default: 
    default: TASK [facts : Set Docker fact to true] *****************************************
    default: skipping: [localhost]
    default: 
    default: TASK [facts : Check for Vagrant related directory] *****************************
    default: ok: [localhost]
    default: 
    default: TASK [facts : Set Vagrant fact to true] ****************************************
    default: ok: [localhost]
    default: 
    default: TASK [nodejs : Include OS-specific variables] **********************************
    default: ok: [localhost]
    default: 
    default: TASK [nodejs : Install Yum Utilities] ******************************************
    default: ok: [localhost]
    default: 
    default: TASK [nodejs : Enable Node.js LTS repository on Fedora] ************************
    default: changed: [localhost]
    default: 
    default: TASK [nodejs : Enable Node.js Current repository on Fedora] ********************
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Install latest Node.js version on Fedora] ***********************
    default: changed: [localhost]
    default: 
    default: TASK [nodejs : Install specific Node.js version on Fedora] *********************
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Install additional RPM packages on Fedora] **********************
    default: changed: [localhost] => (item=[u'git', u'gcc-c++', u'orca', u'glib2-devel', u'PackageKit-glib-devel', u'json-glib-devel', u'libXrandr-devel', u'libXrender-devel', u'libX11-devel', u'xorg-x11-proto-devel', u'alsa-lib-devel', u'tuxguitar', u'v8', u'v8-devel', u'libstdc++', u'gcc-c++', u'gyp', u'http-parser', u'http-parser-devel', u'libstdc++-devel', u'libuv', u'libuv-devel'])
    default: 
    default: TASK [nodejs : Ensure rsync is installed for npm path workaround if a Fedora Vagrant environment is being used] ***
    default: ok: [localhost]
    default: 
    default: TASK [nodejs : Enable Node.js LTS repository on CentOS] ************************
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Enable Node.js Current repository on CentOS] ********************
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Install latest Node.js version on CentOS] ***********************
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Install specific Node.js version on CentOS] *********************
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Fail if nodejs- RPM packages are specified in nodejs_app_rpm_packages] ***
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Install additional RPM packages on CentOS] **********************
    default: skipping: [localhost] => (item=[]) 
    default: 
    default: TASK [nodejs : Enable Yarn repository on CentOS/Fedora] ************************
    default: changed: [localhost]
    default: 
    default: TASK [nodejs : Install Yarn package manager on CentOS/Fedora] ******************
    default: changed: [localhost]
    default: 
    default: TASK [nodejs : Ensure rsync is installed for npm path workaround if a CentOS Vagrant environment is being used] ***
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Adjust npm version] *********************************************
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Install required npm packages] **********************************
    default: changed: [localhost] => (item=grunt-cli)
    default: changed: [localhost] => (item=node-gyp)
    default: 
    default: TASK [nodejs : Install nodemon if a development environment is being used] *****
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Ensure the application group exists] ****************************
    default: changed: [localhost]
    default: 
    default: TASK [nodejs : Ensure the application user account exists] *********************
    default: changed: [localhost]
    default: 
    default: TASK [nodejs : Clone application repository] ***********************************
    default: skipping: [localhost]
    default: 
    default: TASK [nodejs : Make sure the application install directory exists and is owned by the appropriate user] ***
    default: ok: [localhost]
    default: 
    default: TASK [nodejs : Run application related commands as the application user] *******
    default: changed: [localhost] => (item=npm install)
    default: changed: [localhost] => (item=grunt --force build)
    default: 
    default: TASK [gpii-framework : include_tasks] ******************************************
    default: included: /root/.ansible/roles/gpii-framework/tasks/install.yml for localhost
    default: 
    default: TASK [gpii-framework : Install application related RPM packages on Fedora] *****
    default: ok: [localhost] => (item=[u'orca'])
    default: 
    default: TASK [gpii-framework : include_tasks] ******************************************
    default: included: /root/.ansible/roles/gpii-framework/tasks/configure.yml for localhost
    default: 
    default: TASK [gpii-framework : Check to see if the Orca user directory exists] *********
    default: ok: [localhost]
    default: 
    default: TASK [gpii-framework : Create Orca user directory if required] *****************
    default: changed: [localhost]
    default: 
    default: TASK [gpii-framework : Create Orca configuration file] *************************
    default: changed: [localhost]
    default: 
    default: TASK [gpii-framework : Enable and start PackageKit] ****************************
    default: changed: [localhost]
    default: 
    default: PLAY RECAP *********************************************************************
    default: localhost                  : ok=28   changed=12   unreachable=0    failed=0   
==> default: Running provisioner: shell...
    default: Running: inline script



$ vagrant ssh -c 'cd /home/vagrant/sync; $(npm bin)/grunt lint'
Running "eslint:src" (eslint) task
>> 27 files lint free.

Running "jsonlint:src" (jsonlint) task
>> 10 files lint free.

Done.
Connection to 127.0.0.1 closed.




$ npm run test:vagrantUnit
...
11:23:44.429:  jq: ***************
11:23:44.429:  jq: All tests concluded: 114/114 total passed in 49574ms - PASS
11:23:44.430:  jq: ***************



$ npm run test:vagrantAcceptance
...
11:24:34.763:  jq: ***************
11:24:34.763:  jq: All tests concluded: 122/122 total passed in 21441ms - PASS
11:24:34.763:  jq: ***************

@gtirloni gtirloni requested a review from amatas May 23, 2018 11:26
@amatas
Copy link
Contributor

amatas commented May 23, 2018

LGTM but perhaps @javihernandez also wants to review this PR, he knows the latests commands used to launch the tests

@javihernandez
Copy link
Member

Thanks @gtirloni, this looks good to me too.

@gtirloni gtirloni merged commit 787ea72 into GPII:master May 23, 2018
@gtirloni
Copy link
Contributor Author

@javihernandez @amatas thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants