Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3852: Stop showing languages that are removed. #262

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

stegru
Copy link
Member

@stegru stegru commented Apr 12, 2019

This fix stops the QSS from showing languages after they have been removed.

To test:

  1. Install a language, start morphic: the language should be on the pop-up.
  2. Remove the language, restart morphic: the language should no longer be seen.

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/945/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/946/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/948/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/954/

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/955/

@javihernandez
Copy link
Member

ok to test

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/960/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/963/

# Conflicts:
#	gpii/node_modules/WindowsUtilities/WindowsUtilities.js
@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1245/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants