GPII-4011: Showing the volume change on the screen #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI job passed: https://ci.gpii.net/job/windows-tests/998/ |
|
This pull needs some dedicated unit tests for the newly added nativeSettingsHandler code |
|
CI job passed: https://ci.gpii.net/job/windows-tests/1249/ |
|
I'm going to leave this one as-is, and move the volume control in-process later: GPII-4445. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the volume to almost the required value, then uses the shell to perform the final increment causing the volume to show on screen.
The diff shown for VolumeControl.cpp is exaggerated, so here's a picture of the real changes:
