Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPII-4195] Add 1909 and LTSC Windows 10 version to Vagrantfile #314

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

amatas
Copy link

@amatas amatas commented Apr 23, 2020

https://issues.gpii.net/browse/GPII-4195

This PR depends on GPII/ci-service#75. Both should be merged at the same time, otherwise the CI will fail.

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1342/

@amatas
Copy link
Author

amatas commented Apr 24, 2020

ok to test
in order to force the download of the vagrant boxes.

The tests run but the output is mixed due to the tests in both VMs are executed at the same time, before the GPII/ci-service#75 is merged.

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1346/

@amb26
Copy link
Member

amb26 commented Apr 24, 2020

Failure during first CI task:

+ vagrant winrm -c 'do.ps1 -c '\''grunt lint'\'''
This command requires a specific VM name to target in a multi-VM environment.
Build step 'Execute shell' marked build as failure

@amatas
Copy link
Author

amatas commented Apr 24, 2020

Failure during first CI task:

+ vagrant winrm -c 'do.ps1 -c '\''grunt lint'\'''
This command requires a specific VM name to target in a multi-VM environment.
Build step 'Execute shell' marked build as failure

This is expected, the VM name is specified in GPII/ci-service#75

@javihernandez
Copy link
Member

LGTM

So we only need to provide a backwards compatible patch for the language test case.

@javihernandez
Copy link
Member

So we only need to provide a backwards compatible patch for the language test case.

Created PR against @amatas branch with the required changes, see amatas#1

GPII-4195: Updated languageTests to support testing on LTSC and postLTSC
@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1358/

@gpii-bot
Copy link

gpii-bot commented May 6, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1376/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants