Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImmutableString default name of a global variable #97

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

jiaolu
Copy link
Contributor

@jiaolu jiaolu commented Jun 21, 2024

Add name to the global variable as the name is required for the crossliner to include as global variable

@jiaolu jiaolu force-pushed the dev branch 3 times, most recently from 81202fc to cb325b8 Compare June 21, 2024 09:57
The global variable created from ImmutableString must have str name. or
it can not be used  from inlineFunction
@jiaolu jiaolu changed the title Add ImmtableString more properties Add ImmutableString default name of a global variable Jun 24, 2024
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@tsymalla-AMD tsymalla-AMD merged commit f38c271 into GPUOpen-Drivers:dev Jun 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants