Make the Refresh File Tree command clear caches as well to ensure a f…

…ull refresh. As suggested in adobe#7929.
GREdens · Oct 29, 2014 · 8331ec7 · 8331ec7
1 parent e23f7b6
commit 8331ec7
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 3 deletions.
diff --git a/src/filesystem/FileSystem.js b/src/filesystem/FileSystem.js
@@ -816,7 +816,18 @@ define(function (require, exports, module) {
             }
         }
     };
-
+
+    /**
+     * Clears all cached content. Because of the performance implications of this, this should only be used if
+     * there is a suspicion that the file system has not been updated through the normal file watchers
+     * mechanism.
+     */
+    FileSystem.prototype.clearAllCaches = function () {
+        this._index.visitAll(function (entry) {
+            entry._clearCachedData(true);
+        });
+    };
+
     /**
      * Start watching a filesystem root entry.
      * 
@@ -965,6 +976,7 @@ define(function (require, exports, module) {
     exports.showSaveDialog = _wrap(FileSystem.prototype.showSaveDialog);
     exports.watch = _wrap(FileSystem.prototype.watch);
     exports.unwatch = _wrap(FileSystem.prototype.unwatch);
+    exports.clearAllCaches = _wrap(FileSystem.prototype.clearAllCaches);
 
     // Static public utility methods
     exports.isAbsolutePath = FileSystem.isAbsolutePath;

diff --git a/src/project/ProjectModel.js b/src/project/ProjectModel.js
@@ -1075,9 +1075,19 @@ define(function (require, exports, module) {
             });
         }
     };
+
+    /**
+     * @private
+     * 
+     * Clear all caches associated with the project.
+     */
+    ProjectModel.prototype._clearAllCaches = function () {
+        this._resetCache();
+        FileSystem.clearAllCaches();
+    };
 
     /**
-     * Refreshes the contents of the tree.
+     * Clears caches and refreshes the contents of the tree.
      *
      * @return {$.Promise} resolved when the tree has been refreshed
      */
@@ -1088,7 +1098,8 @@ define(function (require, exports, module) {
             selections  = this._selections,
             viewModel   = this._viewModel,
             deferred    = new $.Deferred();
-
+
+        this._clearAllCaches();
         this.setProjectRoot(projectRoot).then(function () {
             self.reopenNodes(openNodes).then(function () {
                 if (selections.selected) {

diff --git a/test/spec/ProjectModel-test.js b/test/spec/ProjectModel-test.js
@@ -1080,6 +1080,7 @@ define(function (require, exports, module) {
 
             it("should refresh the whole tree", function () {
                 var oldTree;
+                spyOn(model, "_clearAllCaches");
                 waitsForDone(model.reopenNodes(data.nodesByDepth));
                 runs(function () {
                     model.setSelected("/foo/subdir1/subsubdir/interior.txt");
@@ -1102,6 +1103,7 @@ define(function (require, exports, module) {
                     expect(vm._treeData.getIn(["subdir1", "children", "subsubdir", "children", "newInterior.txt"])).toBeDefined();
                     expect(vm._treeData.getIn(["subdir1", "children", "subsubdir", "children", "interior.txt"])).toBeUndefined();
                     expect(vm._treeData.getIn(["subdir3", "children", "higher.txt", "context"])).toBe(true);
+                    expect(model._clearAllCaches).toHaveBeenCalled();
                 });
             });
         });