Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement - naming and license #5

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Enhancement - naming and license #5

merged 4 commits into from
Dec 6, 2024

Conversation

KAClough
Copy link
Member

@KAClough KAClough commented Dec 6, 2024

  • Add a license to it and refer to it in the main cpp and cpp files
  • General tidying and old code comment removal
  • Made naming of different vars types consistent
  • Fixed parity so it uses defined enums
  • a_psi_and_Aij_functions_params -> a_psi_and_Aij_params
  • Changed dpsi -> constraint_vars

@KAClough KAClough self-assigned this Dec 6, 2024
@KAClough KAClough added the enhancement New feature or request label Dec 6, 2024
@KAClough
Copy link
Member Author

KAClough commented Dec 6, 2024 •
edited
Loading

Outstanding questions:

  • We only fill V_i boundaries with 0 in extrapolating case - should this not be filled with extrapolating order 0? See lines 355 and 434 in BoundaryConditions.cpp. I have marked with a TODO.
  • Source/Core/GRSolver.impl.hpp - line 255 - some issue with deleting the tagging criterion - remove this?

JCAurre
JCAurre approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@JCAurre JCAurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I like the new way of specifying the parity.

@JCAurre JCAurre merged commit de20873 into main Dec 6, 2024
7 checks passed
@JCAurre
Copy link
Member

JCAurre commented Dec 6, 2024

I have merged this, but we can look into the boundary question in a separate pull request

@KAClough KAClough deleted the enhancement/naming_and_license branch December 6, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCAurre JCAurre JCAurre approved these changes

@SamuelBrady SamuelBrady Awaiting requested review from SamuelBrady

@AreefW AreefW Awaiting requested review from AreefW

Assignees

@KAClough KAClough

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KAClough @JCAurre