Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Libraries (based on dependabot and Snyk) and Refactor Code to … #1579

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jairoanaya
Copy link
Contributor

…Comply to new updates.

Description

Updated libraries and code based on Dependabots and Snyk alerts.
Tested mix tests - working
Tested affected functionality - passed

Related Issues

https://github.com/orgs/GSA/projects/150/views/1?filterQuery=jairo&pane=issue&itemId=92399416&issue=GSA%7CChallenge_gov%7C1500
https://github.com/GSA/Challenge_gov/pulls
https://github.com/orgs/GSA/projects/150/views/1?filterQuery=jairo&pane=issue&itemId=87887260&issue=GSA%7CChallenge_gov%7C1475
https://github.com/orgs/GSA/projects/150/views/1?filterQuery=jairo&pane=issue&itemId=97809117&issue=GSA%7CChallenge_gov%7C1563

Changes Made

Update Elixir Libraries
Update Npm Libraries
Update Elixir and JS code.
Improve function to comply with updated version of Credo.
Ensure warnings are not generated.

Screenshots (if applicable)

See the following screenshots:
image
image
image
image
j4BPg
ZELTj
5dYEX
HjF6R
6tljO
VYexM
ckEUv

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
  • I have added unit tests for new functionality or updated existing tests for changes.
    - [ ] I have updated the documentation/README accordingly, if necessary.
    - [ ] If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
    - [ ] If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.
  • Build has been approved for deployment in CircleCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev to Staging to Production
1 participant