Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission Award / Advancement #84

Open
3 of 43 tasks
r-bartlett-gsa opened this issue Jul 31, 2024 · 2 comments · May be fixed by #397
Open
3 of 43 tasks

Submission Award / Advancement #84

r-bartlett-gsa opened this issue Jul 31, 2024 · 2 comments · May be fixed by #397
Assignees
Labels

Comments

@r-bartlett-gsa
Copy link
Member

r-bartlett-gsa commented Jul 31, 2024

User story

As a challenge manager, in order to keep track which submission are deemed as winners, I would like to be able to indicate winning submissions.

Notes:

  • This is a current functionality on Phoenix app, with submission migration to the Rails, ability to mark awardees/advancement and associated rules need to also be available on the Rails.
    • If a challenge is multi-phased and the second phase is limited only to the previous phase awardees, then only solvers with submissions selected for advancement can participate in later phase entries

Acceptance criteria:

  • On a submission details view for a challenge manager, if all assigned evaluators completed their evaluations, a challenge manager can indicate if a submission is selected to advance
  • Once a submission is marked as selected to advance, the evaluation process for that submission is considered completed and a challenge manager can no longer assign any new evaluators or change any scores of existing evaluators
  • Advancement status is visible on the submission list view, Submissions List View for Evaluators #82
  • Submissions can be sorted by the advancement status, Sort & Filter Submissions #57
  • Advancement indication can be reversed as many times as needed, enabling a challenge manager to assign evaluators and change scores again

Dev tasks:

  • Task 1
  • Task 2

Definition of Done

Doing (dev team)

  • Code complete
  • Code is organized appropriately
  • Any known trade offs are documented in the associated GH issue
  • Code is documented, modules, shared functions, etc.
  • Automated testing has been added or updated in response to changes in this PR
  • The feature is smoke tested to confirm it meets requirements
  • Database changes have been peer reviewed for index changes and performance bottlenecks
  • PR that changes or adds UI
    • include a screenshot of the WAVE report for the altered pages
    • Confirm changes were validated for mobile responsiveness
  • PR approved / Peer reviewed
  • Security scans passed
  • Automate accessibility tests passed
  • Build process and deployment is automated and repeatable
  • Feature toggles if appropriate
  • Deploy to staging
  • Move card to testing column in the board

Staging

  • Accessibility tested (Marni)
    • Keyboard navigation
    • Focus confirmed
    • Color contrast compliance
    • Screen reader testing
  • Usability testing: mobile and desktop (Tracy or Marni)
  • Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
    • Windows/Chrome
    • Windows/Edge
    • Mac/Chrome
    • Mac/Safari
    • iOS/Safari
  • AC review (Renata)
  • Deploy to production (production-like environment for eval capability) (dev team)
  • Move to production column in the board

Production

  • User and security documentation has been reviewed for necessary updates (Renata / Tracy / Dev team)
  • PO / PM approved (Jarah or Renata)
  • AC is met and it works as expected (Jarah or Renata)
  • Move to done column in the board (Jarah or Renata)
@r-bartlett-gsa r-bartlett-gsa changed the title Submission Advancement to Next Phase / Award Submission Award Aug 9, 2024
@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Aug 9, 2024

Some button styles, colors and labels may have changed and screenshots below may reflect outdated styles. Please refer to Figma for latest designs.
Misalignment in styles, colors and labels should not affect the completion of development work. There will be additional user stories towards the end of this epic or MVP to bring uniformity to styles and colors.
If significant difference is noticed in features / functionality, please contact Renata.

Image

@r-bartlett-gsa r-bartlett-gsa changed the title Submission Award Submission Award / Advancement Oct 7, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 02/11/25 milestone Jan 29, 2025
@r-bartlett-gsa
Copy link
Member Author

@stepchud Testing feedback:

  • This criteria is not met: Once a submission is marked as selected to advance, the evaluation process for that submission is considered completed and a challenge manager can no longer assign any new evaluators or change any scores of existing evaluators
  • Bug: on the submission detail if I click "Save" twice without making any checkbox or comment changes, the the checkboxes get disabled and the evaluator tables disappear (even with completed evaluations) https://app.screencast.com/yX5I1WpuH8DMm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants