-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[80] Submission Detail Page #257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stephen Chudleigh <[email protected]>
Co-authored-by: Stephen Chudleigh <[email protected]>
Co-authored-by: Stephen Chudleigh <[email protected]>
eec7ca8
to
032a9ef
Compare
e90ca2f
to
c762f1e
Compare
c762f1e
to
6d3e79a
Compare
stepchud
reviewed
Nov 11, 2024
stepchud
reviewed
Nov 11, 2024
stepchud
reviewed
Nov 11, 2024
stepchud
reviewed
Nov 11, 2024
stepchud
reviewed
Nov 11, 2024
stepchud
reviewed
Nov 11, 2024
2585aa7
to
fc8b85d
Compare
bdf9e58
to
a54f5e9
Compare
bbb4ed7
to
2bf547e
Compare
stepchud
approved these changes
Nov 15, 2024
44 tasks
44 tasks
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a show page for individual submissions. Also adds the concept of comments to submissions so that a challenge manager can leave comments on a submission from this page.
This has consequential merge conflicts now because both the submissions details page (added in this PR) and the submissions list by challenge page are trying to live under the "show" namespace within the manage submissions route & controller.
I made an attempt to merge before I fully understood the problem and the result is the latest commit on this branch. If the last commit is rolled back you will see a fully working feature set but a bunch of merge conflicts.
I think we need to keep the show namespace for displaying details of a single submission and come up with something new for a list of submissions grouped by challenge. This is what "by_challenge_phase" was meant to solve earlier. Some of this confusion is because the manage_submissions/index page isn't a list of submissions, but a list of challenge phases. Maybe that page could exist in its own route and leave the manage_submissions/index namespace open for the list of submissions by challenge phase.
In scope:
Out of scope: