Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[80] Submission Detail Page #257

Merged
merged 37 commits into from
Nov 15, 2024
Merged

[80] Submission Detail Page #257

merged 37 commits into from
Nov 15, 2024

Conversation

stonefilipczak
Copy link
Contributor

@stonefilipczak stonefilipczak commented Nov 7, 2024

Adds a show page for individual submissions. Also adds the concept of comments to submissions so that a challenge manager can leave comments on a submission from this page.

This has consequential merge conflicts now because both the submissions details page (added in this PR) and the submissions list by challenge page are trying to live under the "show" namespace within the manage submissions route & controller.

I made an attempt to merge before I fully understood the problem and the result is the latest commit on this branch. If the last commit is rolled back you will see a fully working feature set but a bunch of merge conflicts.

I think we need to keep the show namespace for displaying details of a single submission and come up with something new for a list of submissions grouped by challenge. This is what "by_challenge_phase" was meant to solve earlier. Some of this confusion is because the manage_submissions/index page isn't a list of submissions, but a list of challenge phases. Maybe that page could exist in its own route and leave the manage_submissions/index namespace open for the list of submissions by challenge phase.

In scope:

  • Submission details (referred to in the design as "Submission Materials")
  • Comment form

Out of scope:

@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 11/19/24 milestone Nov 7, 2024
@stepchud stepchud force-pushed the 80_submission_detail branch from eec7ca8 to 032a9ef Compare November 8, 2024 19:29
@stepchud stepchud force-pushed the 80_submission_detail branch from e90ca2f to c762f1e Compare November 11, 2024 22:45
@stepchud stepchud force-pushed the 80_submission_detail branch from c762f1e to 6d3e79a Compare November 11, 2024 23:43
config/routes.rb Outdated Show resolved Hide resolved
@stepchud stepchud force-pushed the 80_submission_detail branch from 2585aa7 to fc8b85d Compare November 14, 2024 23:49
@stepchud stepchud force-pushed the 80_submission_detail branch from bdf9e58 to a54f5e9 Compare November 15, 2024 00:05
@stepchud stepchud force-pushed the 80_submission_detail branch from bbb4ed7 to 2bf547e Compare November 15, 2024 00:14
@stepchud stepchud merged commit 096c73d into dev Nov 15, 2024
11 checks passed
@stepchud stepchud deleted the 80_submission_detail branch November 15, 2024 00:16
@r-bartlett-gsa r-bartlett-gsa linked an issue Nov 18, 2024 that may be closed by this pull request
44 tasks
@stepchud stepchud linked an issue Nov 20, 2024 that may be closed by this pull request
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submission Detail View for Challenge Managers
3 participants