-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[207] Sort and Filter Component #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback
@stepchud - thanks for help! Those tests weren't failing locally so it was difficult to reproduce, but looks like the tests are good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix that contrast error - lots of little tweaking yesterday to make it responsive and keep the same styling between different screen sizes with USWDS. There was some real weirdness with that built-in USWDS +/- dropdown icon for mobile, I was having a difficult time overriding the styling. I'll give it another go, I wanted to push the other fixes first. Thanks @stepchud ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super close, just a few more backend issues.
Also I'm still seeing the issue "Mobile/tablet layout the menu hover color is low contrast" from my previous comment but I'm not sure that's a blocker since mobile/tablet users can't really hover on a touchscreen. It's just weird that it shows up at that breakpoint, I guess there is something built into the uswds css. I tracked it down to this specific rule if you want to see checkout a way to override that:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Works for me there are some specs failing though
Related tickets: #57 & #207
As a challenge manager, in order to manage the progress of evaluations efficiently, I would like to be able to sort submissions based on submission and evaluation progress data.
Updated UI: