Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[207] Sort and Filter Component #313

Merged
merged 28 commits into from
Jan 6, 2025
Merged

[207] Sort and Filter Component #313

merged 28 commits into from
Jan 6, 2025

Conversation

emmabjj
Copy link
Contributor

@emmabjj emmabjj commented Dec 5, 2024

Related tickets: #57 & #207

As a challenge manager, in order to manage the progress of evaluations efficiently, I would like to be able to sort submissions based on submission and evaluation progress data.

  • Filter
    • Statuses:
      • completed
      • in progress
      • not started
      • recused
    • Eligible for Evaluations
    • Selected to advance
  • Sorting
    • Submission ID: low to high & high to low
    • Average score: low to high & high to low

sort_and_filter

Screenshot 2024-12-05 at 5 29 34 PM Screenshot 2024-12-05 at 5 31 09 PM

Updated UI:
Screenshot 2024-12-27 at 1 58 34 PM
Screenshot 2024-12-27 at 1 58 59 PM

@emmabjj emmabjj self-assigned this Dec 5, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/17/24 milestone Dec 6, 2024
@stepchud stepchud self-requested a review December 10, 2024 22:55
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback

app/controllers/phases_controller.rb Outdated Show resolved Hide resolved
app/controllers/phases_controller.rb Outdated Show resolved Hide resolved
app/models/submission.rb Outdated Show resolved Hide resolved
app/views/phases/_sort_and_filter.html.erb Outdated Show resolved Hide resolved
app/views/phases/_sort_and_filter.html.erb Outdated Show resolved Hide resolved
app/views/phases/_submissions_table.html.erb Outdated Show resolved Hide resolved
app/javascript/controllers/sort_filter_menu_controller.js Outdated Show resolved Hide resolved
app/views/phases/_sort_and_filter.html.erb Outdated Show resolved Hide resolved
spec/requests/phases_spec.rb Outdated Show resolved Hide resolved
@emmabjj
Copy link
Contributor Author

emmabjj commented Dec 19, 2024

@stepchud - thanks for help! Those tests weren't failing locally so it was difficult to reproduce, but looks like the tests are good now.

@emmabjj emmabjj requested a review from stepchud December 19, 2024 23:36
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some UI styling issues that I discovered. I wonder if the custom css in application.sass.scss needs to be tweaked

  1. Mobile/tablet layout the menu hover color is low contrast
  2. The border of the nav menu items is transparent and shows the text behind it
Screenshot 2024-12-20 at 12 26 23 AM

@stepchud
Copy link
Contributor

another small UI issue:
3. The dropdown style should be consistent, on smaller layout is +/- instead of the ^ / ⌄
Screenshot 2024-12-20 at 9 24 12 AM
Screenshot 2024-12-20 at 9 24 19 AM

Some UI styling issues that I discovered. I wonder if the custom css in application.sass.scss needs to be tweaked

  1. Mobile/tablet layout the menu hover color is low contrast
  2. The border of the nav menu items is transparent and shows the text behind it
Screenshot 2024-12-20 at 12 26 23 AM

@emmabjj
Copy link
Contributor Author

emmabjj commented Dec 20, 2024

another small UI issue: 3. The dropdown style should be consistent, on smaller layout is +/- instead of the ^ / ⌄ Screenshot 2024-12-20 at 9 24 12 AM Screenshot 2024-12-20 at 9 24 19 AM

Some UI styling issues that I discovered. I wonder if the custom css in application.sass.scss needs to be tweaked

  1. Mobile/tablet layout the menu hover color is low contrast
  2. The border of the nav menu items is transparent and shows the text behind it
Screenshot 2024-12-20 at 12 26 23 AM

I'll fix that contrast error - lots of little tweaking yesterday to make it responsive and keep the same styling between different screen sizes with USWDS. There was some real weirdness with that built-in USWDS +/- dropdown icon for mobile, I was having a difficult time overriding the styling. I'll give it another go, I wanted to push the other fixes first. Thanks @stepchud !

Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super close, just a few more backend issues.
Also I'm still seeing the issue "Mobile/tablet layout the menu hover color is low contrast" from my previous comment but I'm not sure that's a blocker since mobile/tablet users can't really hover on a touchscreen. It's just weird that it shows up at that breakpoint, I guess there is something built into the uswds css. I tracked it down to this specific rule if you want to see checkout a way to override that:
Screenshot 2025-01-02 at 7 52 23 PM

Screenshot 2025-01-02 at 7 41 49 PM

app/models/submission.rb Outdated Show resolved Hide resolved
app/models/submission.rb Outdated Show resolved Hide resolved
app/controllers/phases_controller.rb Show resolved Hide resolved
app/controllers/phases_controller.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Works for me there are some specs failing though

@emmabjj emmabjj merged commit 8955d31 into dev Jan 6, 2025
10 checks passed
@emmabjj emmabjj deleted the 207_sort_and_filter_component branch January 6, 2025 18:50
@stepchud stepchud linked an issue Jan 6, 2025 that may be closed by this pull request
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the Sort & Filter component
3 participants