[57] Update 'not_started' query

[emmabjj]

Linked ticket: #57

Updated the not_started query to:

• include submissions that do not have an evaluator_submission_assignment yet (brand new submissions)
• include only submissions that are assigned or unassigned
• include evaluations that are nil (not started)

I suspect the error that Renata found while testing, i.e. a submission with a completed evaluation was filtered under not_started, had the submission include an evaluation in which the evaluator had been recused_unassigned. The recused_unassigned evaluator did not show up under the submission row, so the evaluation looked like it was only assigned and completed, which is incorrect for the not_started filter.

[stepchud]

This is a good start but we should add some specs that test these queries better. There is a submissions request spec it 'displays all submissions with status: "submitted" and their status counts but it doesn't fail and we probably need to test several different scenarios anyways. It might be easier to test them in isolation if they're moved into the model instead of in the controller.
Each of these categories are mutually exclusive. A submission can only fall into one of them. As currently written, a submission with a mixture of evaluation progress can be included in different statuses, both for the counts and the filters.

In this example, only submissions 1 & 6 are not_started. 3 & 5 are in_progress. none are completed (all evaluations must be completed). I was working on a related issue with the progress counts last night, it's coming from the same underlying issue in these queries. Maybe we should pair on this to figure out a solution?

EDIT: sorry I even got my explanation wrong. it turns out that submissions that are not "Eligible for Evaluation" are not considered "not_started", i.e. submission 6 is not not_started. this is one of the most complicated queries I've worked on and I'm not even sure it's possible. we also need to factor in recusal and deleted states.