Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital-449: Add guide landing content type to workflow, #217

Merged
merged 7 commits into from
Mar 6, 2025

Conversation

cathybaptista
Copy link
Contributor

@cathybaptista cathybaptista commented Mar 4, 2025

Jira ticket

DIGITAL-449

Purpose

Adds the guide landing page content type to the editorial workflow so that editors can transition this content type.

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

QA/Testing instructions

  1. pull branch
2. lando si
  1. masquerade as publisher
  2. make sure this account can transition guide landing content type.
  3. editors and authors should not be able to transition this content type.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@cathybaptista cathybaptista changed the title Feature/digital 449 add guide landing to workflow Digital-449: Add guide landing content type to workflow, Mar 4, 2025
@cathybaptista cathybaptista marked this pull request as ready for review March 5, 2025 15:00
@cathybaptista cathybaptista requested a review from mattsqd March 5, 2025 15:16
Copy link
Collaborator

@mattsqd mattsqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Cathy, 2 small things:

  • Following the example of the other permissions for editorial content, author and content admin need to be able to create guide landing pages
  • The only guide landing page needs to be published and re-exported

@cathybaptista
Copy link
Contributor Author

@mattsqd changes made. Thanks for having your eyes on that! :)

@cathybaptista cathybaptista requested a review from mattsqd March 6, 2025 17:22
@mattsqd mattsqd merged commit fa81e14 into develop Mar 6, 2025
2 checks passed
@mattsqd mattsqd deleted the feature/DIGITAL-449-add-guide-landing-to-workflow branch March 6, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants