PL - Dependencies: Remediate Babel security issue #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
commented
Jul 22, 2024
There was a problem hiding this comment.
Tip
File is left empty to allow custom JS in the future. Also avoids a build error. The polyfill and jQuery are no longer needed.
| "babel-loader": "^8.2.3", | ||
| "babel-plugin-transform-es2015-modules-commonjs": "^6.26.2", |
There was a problem hiding this comment.
Tip
Now included in @babel/preset-env.
Source →
| "babel-loader": "^8.2.3", | ||
| "babel-plugin-transform-es2015-modules-commonjs": "^6.26.2", | ||
| "babel-preset-es2015": "^6.14.0", |
There was a problem hiding this comment.
Tip
Replaced by @babel/preset-env.
Source →
Comment on lines
-34
to
-36
| "jquery": "^3.7.1", | ||
| "pa11y-ci": "^2.4.2", | ||
| "stickyfilljs": "^2.1.0", |
There was a problem hiding this comment.
Tip
jQuery and stickyfill no longer needed as position sticky is well supported.
clmedders
approved these changes
Jul 24, 2024
rileyseaburg
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing deprecated dependencies and redundant JavaScript. Closes https://github.com/GSA/plainlanguage.gov/security/dependabot/49.
Details
Remove deprecated dependencies
Removed the following deprecated dependencies:
Create NVMRC
Added an NVMRC file to always use the latest LTS version of node. This will help us stay on top of node versions.
Remove sticky polyfill
The only custom JS included was setting an explicit height to prevent a slight jump on hover. Position sticky has good support and didn't notice any issues on pages with sticky sidenav, like
law/agency-programs.Testing
npm run build-jsbuilds without errors.npm auditshows zero vulnerabilities.Impact