Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRCH-5556 Setup package.json to use node v20.10.0 #1684

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

stevenbarragan
Copy link
Contributor

@stevenbarragan stevenbarragan commented Oct 2, 2024

Summary

  • Use node v20.10.0
  • Remove no needed package-lock.json since we're using yarn

Checklist

Please ensure you have addressed all concerns below before marking a PR "ready for review" or before requesting a re-review. If you cannot complete an item below, replace the checkbox with the ⚠️ :warning: emoji and explain why the step was not completed.

Functionality Checks

  • You have merged the latest changes from the target branch (usually main) into your branch.

  • Your primary commit message is of the format SRCH-#### <description> matching the associated Jira ticket.

  • PR title is either of the format SRCH-#### <description> matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or Release - SRCH-####, SRCH-####, SRCH-#### matching the Jira ticket numbers in the release.

  • Automated checks pass. If Code Climate checks do not pass, explain reason for failures:

Process Checks

  • You have specified at least one "Reviewer".

stevenbarragan and others added 2 commits October 1, 2024 14:23
* Remove no needed package-lock.json since we're using yarn
@stevenbarragan stevenbarragan changed the title Setup package.json to use node v20.10.0 SRCH-5556 Setup package.json to use node v20.10.0 Oct 2, 2024
@krbhavith
Copy link
Contributor

@stevenbarragan We also need to update node version in Dockerfile and Dockerfile.dev files

Copy link
Contributor

@krbhavith krbhavith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants