Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #20

Merged
merged 68 commits into from
Oct 28, 2021
Merged

Development #20

merged 68 commits into from
Oct 28, 2021

Conversation

ElhamFadel
Copy link
Contributor

@ElhamFadel ElhamFadel commented Oct 25, 2021

@ElhamFadel ElhamFadel requested a review from NouraldinS October 25, 2021 10:14
Copy link
Collaborator

@NouraldinS NouraldinS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You're missing a build script in your package.json to initialize the database.

server/app.js Outdated Show resolved Hide resolved
server/routes/index.js Outdated Show resolved Hide resolved
@@ -0,0 +1,5 @@
const logout = (req, res) => {
res.clearCookie('token');
res.json({ message: 'logged out Succefully' });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. (This goes to all responses in your system) Do not send plain text messages to the client, always send error codes instead, and leave the client to handle the display of that response.

server/controllers/errors/serverError.js Outdated Show resolved Hide resolved
server/controllers/users/userEstates.js Outdated Show resolved Hide resolved
server/database/connection.js Outdated Show resolved Hide resolved
@Mu7ammadAbed Mu7ammadAbed merged commit badf1bd into main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants