-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development #20
Merged
Merged
Development #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ElhamFadel
commented
Oct 25, 2021
•
edited by mohammedsalah7
Loading
edited by mohammedsalah7
- File Structure File Structure #8
- Server express Create server (express) #5
- Setup database Database setup #4
- create read me README #3
- get all users GET | /users #17
- auth Cookies Authentication middelware (jwt.sign & jwt.verify) #9
- estate by user id
…DME.md in client & package-lock.json to gitignore
create file sturcture
create end point to get all users #17
…4-userId-estates-route
…aery edits to the build.js file
16 logout
authentication tokent
Estates by userId route
NouraldinS
requested changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You're missing a
build
script in your package.json to initialize the database.
server/controllers/logout.js
Outdated
@@ -0,0 +1,5 @@ | |||
const logout = (req, res) => { | |||
res.clearCookie('token'); | |||
res.json({ message: 'logged out Succefully' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- (This goes to all responses in your system) Do not send plain text messages to the client, always send error codes instead, and leave the client to handle the display of that response.
Mu7ammadAbed
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.