Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Review #165

Open
wants to merge 482 commits into
base: initial-commit
Choose a base branch
from
Open

Full Review #165

wants to merge 482 commits into from

Conversation

nada-abuzaid
Copy link

@nada-abuzaid nada-abuzaid commented Jul 4, 2023

  • uninstall @mui/system and update your imports to "@mui/material" in the following files:
/src/pages/admin/dashbored-order/index.jsx
/src/pages/user/signup/index.jsx
/src/pages/user/userSetting/index.jsx
  • In each folder, create index file and import everything from it.
  • be consistent when you naming files, uppercase or lowercase.
  • we you use await for making API requests. It is a good practice to handle potential errors using try-catch blocks.
  • use key when you using map.
  • please check your console and solve any error!
  • if u need to disable any eslint rule please add it in the eslint config file.
  • don't write any color code, use the theme that you created!
  • create a constants folder and set any constant inside in.
  • you're using mui so when you want to display an image, you can use card component, it is recommended to use the CardMedia component instead of the regular img tag.
  • use prettier and remove unwanted white spaces! 😈
  • remove any unused variables and imports.
  • In React 18, you no longer need to import the React object explicitly.
  • In React Router v6, the approach to providing the router context has changed compared to the previous versions-like what you did- so why you don't use this approach as long as you create it?

HamdyPs and others added 30 commits June 26, 2023 15:24
HamdyPs and others added 30 commits July 18, 2023 12:07
…trainersubscription-count-for-class-page

style rest password,get class,trainer,subscription count for class page
…oard-and-client-side

update order status in dashboard and client side
show image instead of url in dashboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants