GET | Get alumnus projects data #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpose I wrote a database query which inner join studnt_project table with project table and send the data from project table, after that I created a function which will handle the route /alumni/:studentId/projects and check the params if every thing is right it will send projects data as a json, if there's something wrong with the inputs a proper response message will be send. After that I do some tests for the function and I achieve 100% test coverage Relates #138
Mu7ammadAbed
added
Awaiting Review
Mu7ammadAbed
requested review from
AlaaSaadeddin,
ranasobeid95,
rehabas and
MohammedAlghazali
3 tasks
MohammedAlghazali
approved these changes
Jun 8, 2020
ranasobeid95
approved these changes
Jun 8, 2020
ranasobeid95
added
Done
and removed
Awaiting Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a route to bring alumnus projects, in order to achieve this purpose I wrote a database query which inner join studnt_project table with project table and send the data from project table.
I created a function which will handle the route /alumni/:studentId/projects and check the params if every thing is right it will send projects data as a json, if there's something wrong with the inputs a proper response message will be send.
After that I do some tests for the function and I achieve 100% test coverage.
Relates #138