GET cohort by id #41
Merged
GET cohort by id #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created query function which search for cohort based on id which came from params, and I created the necessary middleware for this function to work in addition to handling the required /cohort/:cohortid route Relates #19
I created query function which search for cohort based on id which came from params, and I created the necessary middleware for this function to work in addition to handling the required /cohort/:cohortid route Relates #19
Mu7ammadAbed
requested review from
AlaaSaadeddin,
ranasobeid95,
rehabas and
MohammedAlghazali
Mu7ammadAbed
added
Awaiting Review
ranasobeid95
added
Changes Requested
ranasobeid95
requested changes
Mar 29, 2020
Mu7ammadAbed
added
Awaiting Review
| @@ -0,0 +1,21 @@ | |||
| const { | |||
| cohort: { getSpecificCohort }, | |||
There was a problem hiding this comment.
I suggest making destructure of getSpecificCohort in /database/queries/index as :
const { getSpecificCohort } = require('./cohort');
module.exports = { getSpecificCohort };as you make in server/database/queries/cohort/index.js file,
and here in this file you can make require to getSpecificCohort as
Suggested change
| cohort: { getSpecificCohort }, | |
| const { getSpecificCohort } = require('../../../../database/queries'); |
so we get more benefit from /database/queries/index file.
MohammedAlghazali
requested changes
Mar 31, 2020
Merged
MohammedAlghazali
added
Changes Requested
Mu7ammadAbed
added
Awaiting Review
MohammedAlghazali
previously approved these changes
Mar 31, 2020
rehabas
requested changes
Mar 31, 2020
test/index.test.js
Outdated
|
|
||
| const app = require('../server/app'); | ||
|
|
||
| beforeAll(() => { |
There was a problem hiding this comment.
You don't need return here 😉
Suggested change
| beforeAll(() => { | |
| beforeAll(() => dbBuild()); |
| } catch (err) { | ||
| res.status(404).json({ | ||
| statusCode: 404, | ||
| message: "Sorry There's no cohort for this id", |
There was a problem hiding this comment.
Here we need to handle server error
AlaaSaadeddin
previously approved these changes
Mar 31, 2020
Mu7ammadAbed
dismissed stale reviews from AlaaSaadeddin and MohammedAlghazali
via
66c4241
AlaaSaadeddin
approved these changes
Apr 1, 2020
ranasobeid95
approved these changes
Apr 1, 2020
MohammedAlghazali
approved these changes
Apr 1, 2020
rehabas
approved these changes
Apr 1, 2020
ranasobeid95
added
Done
and removed
Awaiting Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created query function which search for cohort based on id which came from params, and I created the necessary middleware for this function to work in addition to handling the required /cohort/:cohortid route
Relates #19