GET cohort/project?type= #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mu7ammadAbed
added
Awaiting Review
Mu7ammadAbed
requested review from
AlaaSaadeddin,
ranasobeid95,
rehabas and
MohammedAlghazali
ranasobeid95
reviewed
Apr 2, 2020
Comment on lines
3
to
4
| const { getCohortProjects } = require('./project'); | ||
| const { addProject, editProject } = require('./project'); |
There was a problem hiding this comment.
Suggested change
| const { getCohortProjects } = require('./project'); | |
| const { addProject, editProject } = require('./project'); | |
| const { addProject, editProject, getCohortProjects } = require('./project'); |
rehabas
approved these changes
Apr 2, 2020
rehabas
previously approved these changes
Apr 2, 2020
AlaaSaadeddin
approved these changes
Apr 2, 2020
rehabas
approved these changes
Apr 2, 2020
ranasobeid95
approved these changes
Apr 2, 2020
MohammedAlghazali
approved these changes
Apr 2, 2020
ranasobeid95
added
Done
and removed
Awaiting Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I handled
/cohorts/:cohortId/projects?type=withGETmethod which require creating a query function you can found atserver/database/queries/project/getCohortProjects.jsand require it at controller function you can found it inserver/controllers/routes/admin/project/getCohortProjects.js.I tried to made some tests hoping they are covering all the cases we would have and all the errors could occur.
Relates #16