Avatar image component #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 138-avatar-image-component
mAbadsa
requested review from
okjake,
yasmeenattallah,
AdhamHaisami and
mariamisa
…to 138-avatar-image-component
okjake
reviewed
Feb 16, 2021
| import Button from '../../../../Components/Button'; | ||
| import useStyles from './style'; | ||
|
|
||
| export default function index() { |
There was a problem hiding this comment.
Instead of index you should give this the component name UserAvatar - it'll help with debugging
okjake
reviewed
Feb 16, 2021
| <div className={classes.formContainer}> | ||
| <form className={classes.avtarForm} onSubmit={handleSubmitImage}> | ||
| <label htmlFor="file-input-select"> | ||
| Chose file |
okjake
reviewed
Feb 16, 2021
| <form className={classes.avtarForm} onSubmit={handleSubmitImage}> | ||
| <label htmlFor="file-input-select"> | ||
| Chose file | ||
| <input |
There was a problem hiding this comment.
I suggest that you add the accepts attribute to the file input to make sure the user can only upload images
okjake
reviewed
Feb 16, 2021
| const [selectedFile, setSelectedFile] = useState(); | ||
| const [errorMsg, setErrorMsg] = useState(''); | ||
|
|
||
| const previewFile = (file) => { |
Relates #138
…to 138-avatar-image-component
…to 138-avatar-image-component
okjake
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#138
UserAvatar Component