Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offhand rendering fixes #50

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Offhand rendering fixes #50

merged 3 commits into from
Jan 19, 2025

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Jan 19, 2025

Closes #27

And also fixes this sillyness where mc thinks both hands are in use while usingthe main hand item and holding something usable in the offhand
backhand

@Lyfts Lyfts requested a review from a team January 19, 2025 15:01
Copy link

Warning: 2 uncommitted changes
pull request create failed: GraphQL: Head sha can't be blank, Base sha can't be blank, Head repository can't be blank, No commits between GTNewHorizons:rendering-fixes and origin:GTNewHorizons-rendering-fixes-spotless-fixes, Head ref must be a branch, not all refs are readable (createPullRequest)

Copy link
Member

@Caedis Caedis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Lyfts Lyfts merged commit 2055c0e into master Jan 19, 2025
1 check passed
@Lyfts Lyfts deleted the rendering-fixes branch January 19, 2025 16:51
@DarianLStephens
Copy link

DarianLStephens commented Jan 20, 2025

Oh, did this or the previous commit fix the issue where you see what was previously in your offhand when putting an item in to it after it had been emptied?
For example, if you put a torch in your offhand, then took them out, and later put a block of dirt in your offhand, you'd see the torch for a split second before it switched to rendering dirt?

EDIT: Ah, yes, that issue mentions it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no transition animation when switching an item to Offhand
3 participants