Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labs 2,3,4,5 submission #12

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

Braveoneone
Copy link

No description provided.

@RasmusBlanck
Copy link
Contributor

Good work. You can also add an autostart using the 'after' construct in xstate. Also, 'guard' is the xstate 5 terminology, while they were called 'cond' in xstate 4 and earlier. I'm not sure how backwards compatible the new version is, so perhaps this is the source of your cond/guard problems.

@vladmaraev vladmaraev force-pushed the main branch 2 times, most recently from 79e44e6 to 389c1aa Compare February 20, 2024 15:55
@vladmaraev vladmaraev force-pushed the main branch 2 times, most recently from f89ca27 to 96cbfe4 Compare February 23, 2024 09:09
@Braveoneone Braveoneone changed the title Lab 2 submission Lab 2,3 submission Feb 26, 2024
@Braveoneone Braveoneone changed the title Lab 2,3 submission Labs 2,3 submission Feb 26, 2024
@Braveoneone Braveoneone changed the title Labs 2,3 submission Labs 2,3,4 submission Mar 1, 2024
@Braveoneone Braveoneone changed the title Labs 2,3,4 submission Labs 2,3,4,5 submission Mar 10, 2024
@RasmusBlanck
Copy link
Contributor

Comments lab 4:

It's a bit surprising that your submission does not implement the flow chart from lab 2, but your submission still basically shows that you can do what was asked of you, so I'm going to pass you.

Comments lab 5:

The system crashes on out-of-grammar meeting titles. This must be fixed, since you can not expect the user to know in advance exactly what meeting titles would be accepted, and making sure that out-of-grammar situations are handled correctly is one of the main tasks of lab 5.

@Braveoneone
Copy link
Author

thanks for your @RasmusBlanck reply! I have modified the grammar section and test them. I think 'not in grammar' works right now. Could you help test them again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants