-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lab 2, 3, 4, 5 submission #13
base: main
Are you sure you want to change the base?
Conversation
389c1aa
to
f89ca27
Compare
Hey! The machine works, but there are some important fixes to be made:
For next lab (lab4), try defining actions at the top of your machine (like said in the instructions for lab 2) and try adding more time in the autostart. Message me if you need some help with this, please! |
I added the things that you told me in the lab2 and accidentally I pushed it 2 times. Its the same file |
Hey, for lab5, it works fine, but there are a couple of issues:
Message me if you need some help fixing these things. |
Hey,
I have the help in all stages, I don't know what's the problem and for the
second problem I have this guard that I remember it worked normally. I used
the same in lab 4 as well. I can add the out of grammar examples if it's
necessary in order to be complete.
{guard: ({event}) => IsPositive(event.nluValue.entities[0].category),
target: "CreateAppointment"},
{guard: ({event}) => IsNegative(event.nluValue.entities[0].
category),
target: "#DM.PromptAndAsk.Askwithwhom"},
Στις Παρ 22 Μαρ 2024 στις 11:22 μ.μ., ο/η nastaiza14 <
***@***.***> έγραψε:
… Hey, for lab5, it works fine, but there are a couple of issues:
- "help" cannot be called at any stage
- there is some sort of error before confirming the appointment, it
doesn't accept nor reject the confirmation, then it reformulates the prompt
and jumps back to the beginning
- out of grammar examples are not handled, for example, if I say that
I want an appointment with the queen of Sweden, it will give an error. I
think you already know how to handle this type of error, related to the
detection of the array of entities ;)
Message me if you need some help fixing these things.
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFZ3BLOBYY4QH3QFRROTU33YZSVJTAVCNFSM6AAAAABDNJ7KFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGAYTOMBTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I have uploaded now the revised version with the out of grammar examples.
Στις Σάβ 23 Μαρ 2024 στις 12:06 π.μ., ο/η Victoria Daniilidou <
***@***.***> έγραψε:
… Hey,
I have the help in all stages, I don't know what's the problem and for the
second problem I have this guard that I remember it worked normally. I used
the same in lab 4 as well. I can add the out of grammar examples if it's
necessary in order to be complete.
{guard: ({event}) => IsPositive(event.nluValue.entities[0].category),
target: "CreateAppointment"},
{guard: ({event}) => IsNegative(event.nluValue.entities[0
].category),
target: "#DM.PromptAndAsk.Askwithwhom"},
Στις Παρ 22 Μαρ 2024 στις 11:22 μ.μ., ο/η nastaiza14 <
***@***.***> έγραψε:
> Hey, for lab5, it works fine, but there are a couple of issues:
>
> - "help" cannot be called at any stage
> - there is some sort of error before confirming the appointment, it
> doesn't accept nor reject the confirmation, then it reformulates the prompt
> and jumps back to the beginning
> - out of grammar examples are not handled, for example, if I say that
> I want an appointment with the queen of Sweden, it will give an error. I
> think you already know how to handle this type of error, related to the
> detection of the array of entities ;)
>
> Message me if you need some help fixing these things.
>
> —
> Reply to this email directly, view it on GitHub
> <#13 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BFZ3BLOBYY4QH3QFRROTU33YZSVJTAVCNFSM6AAAAABDNJ7KFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGAYTOMBTGU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Hey, the issue is that your first guard is checking the length of entities and, for example, an intent of "help" may not have any, so the first thing caught is the "I don't understand" in some cases. Try finding a workaround. Anyway, let me know if you find a way! |
Since the issue is addressed in the final project, we have decided that this is fine! |
Thanks a lot!
Στις Πέμ, 28 Μαρ 2024, 14:52 ο χρήστης nastaiza14 ***@***.***>
έγραψε:
… Since the issue is addressed in the final project, we have decided that
this is fine!
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFZ3BLPEQVXCI7GYLZQ2TODY2QHCPAVCNFSM6AAAAABDNJ7KFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVGIZTSNRXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
report-lab2.pdf