Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab 2, 3, 4, 5 submission #13

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Conversation

Viktoriada26
Copy link

@vladmaraev vladmaraev force-pushed the main branch 3 times, most recently from 389c1aa to f89ca27 Compare February 21, 2024 08:44
@nastaiza14
Copy link
Collaborator

Hey! The machine works, but there are some important fixes to be made:

  • when an element is not in the grammar, I saw that you target "Done", but this breaks the flow of the dialogue. You could have something like "that doesn't work, try with an element in the grammar" and then send the person back to the question.

  • Also, in "Will it take the whole day?" and the confirmation states, if we have a timeout, the machine will go to "Done", so it's a good idea to also have an "Are you there?" state in these parts too, so the progress of the user isn't lost.

  • And a minor fix to be made is that when the confirmation state involves the "Whole day" (whole day = yes) the machine says "Do you want to meet {Vlad} on {Tuesday} at { }?", and we don't want to just leave that blank. One way to fix this is using two different states whether the appointment takes the whole day or not

For next lab (lab4), try defining actions at the top of your machine (like said in the instructions for lab 2) and try adding more time in the autostart.

Message me if you need some help with this, please!

@Viktoriada26 Viktoriada26 changed the title Lab 2 submission Lab 2, 3(taskb) submission Feb 27, 2024
@Viktoriada26
Copy link
Author

I added the things that you told me in the lab2 and accidentally I pushed it 2 times. Its the same file

@Viktoriada26 Viktoriada26 changed the title Lab 2, 3(taskb) submission Lab 2, 3(taskb), 4 submission Mar 4, 2024
@Viktoriada26 Viktoriada26 changed the title Lab 2, 3(taskb), 4 submission Lab 2, 3, 4 submission Mar 5, 2024
@Viktoriada26 Viktoriada26 changed the title Lab 2, 3, 4 submission Lab 2, 3, 4, 5 submission Mar 8, 2024
@nastaiza14
Copy link
Collaborator

Hey, for lab5, it works fine, but there are a couple of issues:

  • "help" cannot be called at any stage
  • there is some sort of error before confirming the appointment, it doesn't accept nor reject the confirmation, then it reformulates the prompt and jumps back to the beginning
  • out of grammar examples are not handled, for example, if I say that I want an appointment with the queen of Sweden, it will give an error. I think you already know how to handle this type of error, related to the detection of the array of entities ;)

Message me if you need some help fixing these things.

@Viktoriada26
Copy link
Author

Viktoriada26 commented Mar 22, 2024 via email

@Viktoriada26
Copy link
Author

Viktoriada26 commented Mar 22, 2024 via email

@nastaiza14
Copy link
Collaborator

Hey, the issue is that your first guard is checking the length of entities and, for example, an intent of "help" may not have any, so the first thing caught is the "I don't understand" in some cases. Try finding a workaround.
Something similar happens in the confirmation for the "whole day": the entity array is not empty, but the "category" doesn't seem to match... you have functions (IsPositive/IsNegative) that equated event to "positive" or "negative", but the category is "negativenaswer", in your NLU. I don't really understand what those functions do, but maybe try changing something like that.

Anyway, let me know if you find a way!

@nastaiza14
Copy link
Collaborator

Since the issue is addressed in the final project, we have decided that this is fine!

@Viktoriada26
Copy link
Author

Viktoriada26 commented Mar 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants